From: Boris Brezillon <bbrezillon@kernel.org>
To: Przemyslaw Gaj <pgaj@cadence.com>
Cc: linux-i3c@lists.infradead.org, psroka@cadence.com,
rafalc@cadence.com, vitor.soares@synopsys.com
Subject: Re: [PATCH] i3c: master: cdns: fix I2C transfers in Cadence I3C master driver
Date: Wed, 12 Dec 2018 17:10:08 +0100 [thread overview]
Message-ID: <20181212171008.170be7d6@bbrezillon> (raw)
In-Reply-To: <1544614780-21553-1-git-send-email-pgaj@cadence.com>
On Wed, 12 Dec 2018 11:39:40 +0000
Przemyslaw Gaj <pgaj@cadence.com> wrote:
> This patch fixes I2C transfers in Cadence I3C master driver.
> There was no way to queue more than one I2C transfer before.
>
> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
Queued to i3c/next (after adding the Fixes tag I mentioned in my
previous reply).
Thanks,
Boris
> ---
> drivers/i3c/master/i3c-master-cdns.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> index 4f59942..02a8297 100644
> --- a/drivers/i3c/master/i3c-master-cdns.c
> +++ b/drivers/i3c/master/i3c-master-cdns.c
> @@ -836,7 +836,7 @@ static int cdns_i3c_master_i2c_xfers(struct i2c_dev_desc *dev,
> return -ENOMEM;
>
> for (i = 0; i < nxfers; i++) {
> - struct cdns_i3c_cmd *ccmd = &xfer->cmds[0];
> + struct cdns_i3c_cmd *ccmd = &xfer->cmds[i];
>
> ccmd->cmd0 = CMD0_FIFO_DEV_ADDR(xfers[i].addr) |
> CMD0_FIFO_PL_LEN(xfers[i].len) |
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
parent reply other threads:[~2018-12-12 16:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1544614780-21553-1-git-send-email-pgaj@cadence.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212171008.170be7d6@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=psroka@cadence.com \
--cc=rafalc@cadence.com \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox