From: Boris Brezillon <bbrezillon@kernel.org>
To: Vitor Soares <vitor.soares@synopsys.com>
Cc: linux-i3c@lists.infradead.org, joao.pinto@synopsys.com
Subject: Re: [PATCH] i3c: master: dw-i3c-master: fix i3c_attach/reatach
Date: Wed, 9 Jan 2019 18:48:46 +0100 [thread overview]
Message-ID: <20190109184846.56c75c3f@bbrezillon> (raw)
In-Reply-To: <2e33e1f72db978f77ced019ae085c972050ca4e9.1547040890.git.vitor.soares@synopsys.com>
On Wed, 9 Jan 2019 15:58:05 +0100
Vitor Soares <vitor.soares@synopsys.com> wrote:
> This patch fix i3c attach/reatach functions.
>
> During the i3c_attach the driver doesn't threat the static address used for
^treat?
> SETDASA CCC command.
Or maybe
"
During the i3c_attach the driver *ignores* the static address used for ...
"
>
> During the i3c_reatach the driver doesn't update master->addrs[data->index] with
^reattach
> new address if old_dyn_addr = 0.
>
Missing Fixes tag here:
Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> ---
> drivers/i3c/master/dw-i3c-master.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index b532e2c..b84acbc 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -901,9 +901,6 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev,
> master->regs +
> DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index));
>
> - if (!old_dyn_addr)
> - return 0;
> -
> master->addrs[data->index] = dev->info.dyn_addr;
>
> return 0;
> @@ -925,11 +922,11 @@ static int dw_i3c_master_attach_i3c_dev(struct i3c_dev_desc *dev)
> return -ENOMEM;
>
> data->index = pos;
> - master->addrs[pos] = dev->info.dyn_addr;
> + master->addrs[pos] = dev->info.dyn_addr ?: dev->info.static_addr;
^ add a space between '?' and ':'
> master->free_pos &= ~BIT(pos);
> i3c_dev_set_master_data(dev, data);
>
> - writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr),
> + writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(master->addrs[pos]),
> master->regs +
> DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index));
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-01-09 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 14:58 [PATCH] i3c: master: dw-i3c-master: fix i3c_attach/reatach Vitor Soares
2019-01-09 17:48 ` Boris Brezillon [this message]
2019-01-10 15:16 ` vitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109184846.56c75c3f@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=joao.pinto@synopsys.com \
--cc=linux-i3c@lists.infradead.org \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox