Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through

Gustavo A. R. Silva
2019-02-27T03:53:23Z

Hi all,

Friendly ping:

Who can ack or review this, please?

Thanks
--
Gustavo

On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
> drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (ret)
> ^
> drivers/i3c/master/dw-i3c-master.c:605:2: note: here
> case I3C_BUS_MODE_PURE:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/i3c/master/dw-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index bb03079fbade..59279224e07f 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
> ret = dw_i2c_clk_cfg(master);
> if (ret)
> return ret;
> + /* fall through */
> case I3C_BUS_MODE_PURE:
> ret = dw_i3c_clk_cfg(master);
> if (ret)