Re: [PATCH v4 3/6] i3c: Add support for mastership request to I3C subsystem

Boris Brezillon
2019-04-12T14:57:29Z

On Fri, 12 Apr 2019 14:28:26 +0000
Vitor Soares <vitor.soares@synopsys.com> wrote:

> > > What if the slave is a secondary master? In your opinion what should be
> > > the flow?
> >
> > i3c_slave_regiter(&ctrl->slave);
> > i3c_master_regiter(&ctrl->master);
> >
> > The order is arbitrary, and those might actually be called from
> > different path if it makes more sense. I'm just pointing out that
> > registering a slave and registering a master are 2 different things,
> > and the master side of the framework should probably not automate slave
> > registration, at least not until we have a better idea of what the
> > slave API will look like.
>
> We need to understand better your point.
>
> The secondary master can have both roles and even not implementing all
> slave function it is a slave when is not a master.
> For me still keep the idea:
>
> bus
> / \
> / \
> slave master
>
> and just one role is active at time.
>
> I didn't get why the bus shouldn't be instantiated for slave. Can you
> explain?

Because, from a SW PoV, pure slave devices don't care about the bus
concept. Do you have use cases where you'd need to know what bus the
slave is connected to?

AFAICT, all you can do is reply to master requests (probably with some
predefined messages, like values stored in a regmap or data queued in
a FIFO).

>
> In any case we will need a common point to switch the roles.

We'd need a way to relinquish bus ownership, that's all. When the
master is not the current master, it automatically becomes a slave, and
if it has any "I3C slave" profile registered, it can reply to requests
coming from the current master.

> > > > > > > In this way you are able to add DEFSLVS even before the HC has enable MR
> > > > > > events like it is done
> > > > > > > with dt devices.
> > > > > >
> > > > > > I don't get it. What do you mean "add DEFSLVS"? DEFSLVS should be received
> > > > > > from
> > > > > > current master right after ENTDAA. Could you please explain?
> > > > >
> > > > > So the current master receive an hot join and send the DEFSLVS, when do you
> > > > > add them to the bus? Will you go for the all process to get all dev info and so on?
> > > > >
> > > >
> > > > When current master receives an hot-join, do ENTDAA to enumerate device which
> > > > joined the bus and then sends DEFSLVS. This data is stored in secondary master
> > > > controller and if secondary master can request mastership, collects all
> > > > required informations and adds the devices. It has to collect PID, DEFSLVS does
> > > > not provide this information.
> > >
> > > I see now. You need to take care here because when the secondary master
> > > add the i3c_dev it might change the address.
> > > This is one of the reasons I would prefer a dedicated function to add the
> > > DEFSLVS.
> >
> > IIRC, Cadence IP is parsing DEFSLVS in HW, and the device table is
> > automatically filled based on that. We should only add the DEFSLVS
> > parsing helper once we start seeing a need for it (probably when adding
> > secondary slave support since you seem to insist on this aspect :-)).
>
> For me the subsystem should hold and handle all this information. Anyway,
> this information is received and needed before the mastership takeover.

It is, and we already have a bunch of helpers to add new devices. Maybe
we need a few more, I'm just saying that forging a DEFSLVS frame to then
pass it to the core is not the right solution IMO. If you need an helper
that automatically parses a DEFSLVS frame and add the new devices, then
fine, add this helper to the framework and use it in your driver, but
don't force other drivers to use this method.

> Basically I want to avoid to put this type of logistics in HC driver
> layer and call the maintenance_lock.

And yet, I don't think forging a DEFSLVS frame is the right way to
provide the kind of abstraction you're talking about. Note that I said
a few things should be provided as helpers in my review.

>
> I'm insisting because it seems that I have a different use case to
> address and I don't see how this fit on it.

Can you be more specific, because we don't know about your use cases.