Re: [PATCH v4 1/6] i3c: add addr and lvr to i2c_dev_desc structure

Boris Brezillon
2019-03-30T14:36:27Z

On Sun, 10 Mar 2019 13:58:38 +0000
Przemyslaw Gaj <pgaj@cadence.com> wrote:

> I need to store address and lvr value for I2C devices without static definition
> in DT. This allows secondary master to transmit DEFSLVS command properly.
>
> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
> ---
> include/linux/i3c/master.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
> index eca8337..3c27d9f 100644
> --- a/include/linux/i3c/master.h
> +++ b/include/linux/i3c/master.h
> @@ -71,6 +71,9 @@ struct i2c_dev_boardinfo {
> * @common: common part of the I2C device descriptor
> * @boardinfo: pointer to the boardinfo attached to this I2C device
> * @dev: I2C device object registered to the I2C framework
> + * @addr: I2C device address
> + * @lvr: LVR (Legacy Virtual Register) needed by the I3C core to know about
> + * the I2C device limitations
> *
> * Each I2C device connected on the bus will have an i2c_dev_desc.
> * This object is created by the core and later attached to the controller
> @@ -84,6 +87,8 @@ struct i2c_dev_desc {
> struct i3c_i2c_dev_desc common;
> const struct i2c_dev_boardinfo *boardinfo;
> struct i2c_client *dev;
> + u16 addr;
> + u8 lvr;

You also need to remove lvr from i2c_dev_boardinfo and adjust the code
to use i2c_dev_desc->addr and i2c_dev_desc->lvr in this patch, not in
patch 3.

> };
>
> /**