Re: [PATCH v4 0/4] Drop support for I2C 10 bit devices from I3C subsystem

Boris Brezillon
2019-04-16T05:28:03Z

On Tue, 16 Apr 2019 05:41:42 +0100
Przemyslaw Gaj <pgaj@cadence.com> wrote:

> I3C MIPI spec does not clearly say that I2C 10bit devices are supported.
> Additionally, it isn't possible to pass 10 bit device properly through DEFSLVS
> command and reserve address for such device on secondary master side.
>
> Main changes between v3 and v4:
> - Fix changelogs
> - Fix patch versioning
> - Change order of the patches to make it bisectable.
>
> Przemyslaw Gaj (4):
> i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence
> I3C master
> i3c: master: dw-i3c-master: Remove i2c_funcs hook implementation
> i3c: Drop support for I2C 10 bit addresing

Sorry, but this is still breaking bisectability. If you run the kernel
after applying the first 2 patches you get a NULL pointer dereference.
Please merge patches 1 to 3 into a single patch, that's the simplest
solution.

> dt-bindings: i3c: Document dropped support for I2C 10 bit devices
>
> Documentation/devicetree/bindings/i3c/i3c.txt | 4 +++-
> drivers/i3c/master.c | 21 ++++++++++++++-------
> drivers/i3c/master/dw-i3c-master.c | 6 ------
> drivers/i3c/master/i3c-master-cdns.c | 10 +---------
> include/linux/i3c/master.h | 5 +----
> 5 files changed, 19 insertions(+), 27 deletions(-)
>