From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C79BC25AED for ; Fri, 30 Jul 2021 19:40:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDDDC60F26 for ; Fri, 30 Jul 2021 19:40:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CDDDC60F26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fm82ncs43JO8Al+lFwBijLrmdo3oWJCgASmip8EKpiw=; b=fGLz4y45kTpin+ SYhwKXCVX6WBehJXntpRHZG24hXt7vE5AD6skyblzLL2eb5tNxwR8NMzpPT7GgDgq9S3to7ob+tHU 9pFbQEJvdIgruKvFitPsRqUG5fBONvtUAnqX1h90qRNH/kNXgfD+RIFwsYxtGT5ItvHVexUq0UfCA oIcbgE1zIoPLjoDNgNNXz1UkieQFYtC0tgH+2jkZGMaVovIMIDyR21XzfjNNYUmHATx4lX/2P3xpr yvundZw7QLxrq02ft3v3mt350l+g9gr0zTHqSAymNadDvih1UHH++boXgljgsgh3oAYwkkaLSKkv6 /vCAVksaYG4ggC7rYGVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9YN2-00A8cM-1j; Fri, 30 Jul 2021 19:40:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3c6X-00D87j-Nv; Wed, 14 Jul 2021 10:27:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3209A1042; Wed, 14 Jul 2021 03:27:00 -0700 (PDT) Received: from bogus (unknown [10.57.79.213]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FF633F774; Wed, 14 Jul 2021 03:26:27 -0700 (PDT) Date: Wed, 14 Jul 2021 11:25:29 +0100 From: Sudeep Holla To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Greg Kroah-Hartman , kernel@pengutronix.de, Sudeep Holla , Alexander Shishkin , Alexandre Belloni , Alexandre Bounine , Alex Dubov , Alex Elder , Alex Williamson , Alison Schofield , Allen Hubbe , Andreas Noever , Andy Gross , Arnd Bergmann , Benjamin Herrenschmidt , Benjamin Tissoires , Ben Widawsky , Bjorn Andersson , Bjorn Helgaas , Bodo Stroesser , Boris Ostrovsky , Chen-Yu Tsai , Christian Borntraeger , Cornelia Huck , Cristian Marussi , Dan Williams , Dave Jiang , "David S. Miller" , David Woodhouse , Dexuan Cui , Dmitry Torokhov , Dominik Brodowski , Finn Thain , Florian Fainelli , Frank Li , Geert Uytterhoeven , Geoff Levand , Haiyang Zhang , Hannes Reinecke , Hans de Goede , Harald Freudenberger , Heikki Krogerus , Heiko Carstens , Helge Deller , Ira Weiny , Jakub Kicinski , "James E.J. Bottomley" , Jaroslav Kysela , Jason Wang , Jens Taprogge , Jernej Skrabec , Jiri Kosina , Jiri Slaby , Joey Pabalan , Johan Hovold , Johannes Berg , Johannes Thumshirn , Jon Mason , Juergen Gross , Julien Grall , Kai-Heng Feng , Kirti Wankhede , Kishon Vijay Abraham I , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "K. Y. Srinivasan" , Lee Jones , Len Brown , Lorenzo Pieralisi , Manohar Vanga , Marc Zyngier , Mark Brown , Mark Gross , "Martin K. Petersen" , Martyn Welch , Mathieu Poirier , Matt Porter , Mauro Carvalho Chehab , Maxime Ripard , Maximilian Luz , Maxim Levitsky , Michael Buesch , Michael Ellerman , Michael Jamet , "Michael S. Tsirkin" , Mika Westerberg , Mike Christie , Moritz Fischer , Ohad Ben-Cohen , Pali =?utf-8?B?Um9ow6Fy?= , Paul Mackerras , Peter Oberparleiter , "Rafael J. Wysocki" , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rich Felker , Rikard Falkeborn , Rob Herring , Russell King , "Russell King (Oracle)" , Samuel Holland , Samuel Iglesias Gonsalvez , SeongJae Park , Srinivas Kandagatla , Srinivas Pandruvada , Stefano Stabellini , Stefan Richter , Stephen Boyd , Stephen Hemminger , Sven Van Asbroeck , Takashi Iwai , Thomas Bogendoerfer , Thorsten Scherer , Tomas Winkler , Tom Rix , Tyrel Datwyler , Ulf Hansson , Vasily Gorbik , Vineeth Vijayan , Vinod Koul , Vishal Verma , Wei Liu , William Breathitt Gray , Wolfram Sang , Wu Hao , Yehezkel Bernat , Yoshinori Sato , YueHaibing , Yufen Yu , alsa-devel@alsa-project.org, dmaengine@vger.kernel.org, greybus-dev@lists.linaro.org, industrypack-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fpga@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-ntb@googlegroups.com, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, nvdimm@lists.linux.dev, platform-driver-x86@vger.kernel.org, sparclinux@vger.kernel.org, target-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Johannes Thumshirn , "Rafael J . Wysocki" Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void Message-ID: <20210714102529.ehwquc2s2qlbccyg@bogus> References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_032701_920617_06E61BEC X-CRM114-Status: GOOD ( 24.41 ) X-Mailman-Approved-At: Fri, 30 Jul 2021 12:40:21 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-K=F6nig wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > = > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > = > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > = [...] > diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/= bus.c > index 784cf0027da3..2682c3df651c 100644 > --- a/drivers/firmware/arm_scmi/bus.c > +++ b/drivers/firmware/arm_scmi/bus.c > @@ -116,15 +116,13 @@ static int scmi_dev_probe(struct device *dev) > return scmi_drv->probe(scmi_dev); > } > = > -static int scmi_dev_remove(struct device *dev) > +static void scmi_dev_remove(struct device *dev) > { > struct scmi_driver *scmi_drv =3D to_scmi_driver(dev->driver); > struct scmi_device *scmi_dev =3D to_scmi_dev(dev); > = > if (scmi_drv->remove) > scmi_drv->remove(scmi_dev); > - > - return 0; > } > = > static struct bus_type scmi_bus_type =3D { Acked-by: Sudeep Holla -- Regards, Sudeep -- = linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c