From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-i3c@lists.infradead.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH 10/12] i3c: mipi-i3c-hci: Fix missing xfer->completion in hci_cmd_v1_daa()
Date: Thu, 21 Sep 2023 08:57:02 +0300 [thread overview]
Message-ID: <20230921055704.1087277-11-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <20230921055704.1087277-1-jarkko.nikula@linux.intel.com>
Due to missing completion object for the ENTDAA command transfer in the
hci_cmd_v1_daa() the wait_for_completion_timeout() will obviously
timeout even the transfer itself may succeed.
Fix this by setting the xfer->completion to the already initialized
completion object.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
index 6a781f89b0e4..2b2323aa6714 100644
--- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
+++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
@@ -332,6 +332,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
CMD_A0_DEV_COUNT(1) |
CMD_A0_ROC | CMD_A0_TOC;
xfer->cmd_desc[1] = 0;
+ xfer->completion = &done;
hci->io->queue_xfer(hci, xfer, 1);
if (!wait_for_completion_timeout(&done, HZ) &&
hci->io->dequeue_xfer(hci, xfer, 1)) {
--
2.40.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-09-21 5:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 5:56 [PATCH 00/12] i3c: mipi-i3c-hci: Enabling fixes Jarkko Nikula
2023-09-21 5:56 ` [PATCH 01/12] i3c: master: Inherit DMA masks and parameters from parent device Jarkko Nikula
2023-09-21 5:56 ` [PATCH 02/12] i3c: mipi-i3c-hci: Add MODULE_ALIAS Jarkko Nikula
2023-09-21 5:56 ` [PATCH 03/12] i3c: mipi-i3c-hci: Fix DAT/DCT entry sizes Jarkko Nikula
2023-09-21 5:56 ` [PATCH 04/12] i3c: mipi-i3c-hci: Fix out of bounds access in hci_dma_irq_handler Jarkko Nikula
2023-09-21 5:56 ` [PATCH 05/12] i3c: mipi-i3c-hci: Remove BUG() when Ring Abort request times out Jarkko Nikula
2023-09-21 5:56 ` [PATCH 06/12] i3c: mipi-i3c-hci: Set ring start request together with enable Jarkko Nikula
2023-09-21 5:56 ` [PATCH 07/12] i3c: mipi-i3c-hci: Fix race between bus cleanup and interrupt Jarkko Nikula
2023-09-21 5:57 ` [PATCH 08/12] i3c: mipi-i3c-hci: Set number of SW enabled Ring Bundles earlier Jarkko Nikula
2023-09-21 5:57 ` [PATCH 09/12] i3c: mipi-i3c-hci: Do not unmap region not mapped for transfer Jarkko Nikula
2023-09-21 5:57 ` Jarkko Nikula [this message]
2023-09-21 5:57 ` [PATCH 11/12] i3c: mipi-i3c-hci: Resume controller explicitly Jarkko Nikula
2023-09-21 5:57 ` [PATCH 12/12] i3c: mipi-i3c-hci: Resume controller after aborted transfer Jarkko Nikula
2023-09-25 21:36 ` [PATCH 00/12] i3c: mipi-i3c-hci: Enabling fixes Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921055704.1087277-11-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox