Re: [PATCH 4/5] i3c: master: svc return actual transfer data len

Jarkko Nikula
2023-10-17T08:33:43Z

Hi

On 10/16/23 18:46, Frank Li wrote:
> I3C allow devices early terminate data transfer. So set "actual" to
> indicate how much data get by i3c_priv_xfer.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 3570b709cf60..444825aafa6f 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -138,6 +138,7 @@ struct svc_i3c_cmd {
> const void *out;
> unsigned int len;
> unsigned int actual_len;
> + struct i3c_priv_xfer *xfer;
> bool continued;
> };
>
I'm thinking would it make sense to combine this and previous patch by
removing the read_len/actual_len variable from this structure and use
the added one (by the patch 2/5) from "struct i3c_priv_xfer" directly?