Re: [PATCH 2/5] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-slave

Krzysztof Kozlowski
2023-10-19T07:00:57Z

On 18/10/2023 23:58, Frank Li wrote:
> Add compatible string 'silvaco,i3c-slave' for slave mode.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index 133855f11b4f5..63db63f00a509 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Silvaco I3C master
> +title: Silvaco I3C master/slave
>
> maintainers:
> - Conor Culhane <conor.culhane@silvaco.com>
> @@ -14,8 +14,10 @@ allOf:
>
> properties:
> compatible:
> - const: silvaco,i3c-master-v1
> -
> + const:
> + enum:
> + - silvaco,i3c-master-v1
> + - silvaco,i3c-slave-v1

Missing blank line.

Rather choose name from Coding style.

Best regards,
Krzysztof