Re: [PATCH 1/5] i3c: add slave mode support

Krzysztof Kozlowski
2023-10-19T07:00:20Z

On 18/10/2023 23:58, Frank Li wrote:
> Introduce a new slave core layer in order to support slave functions in
> linux kernel. This comprises the controller library and function library.
> Controller library implements functions specific to an slave controller
> and function library implements functions specific to an slave function.
>
> Introduce a new configfs entry to configure the slave function configuring
> and bind the slave function with slave controller.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/i3c/Kconfig | 26 ++
> drivers/i3c/Makefile | 2 +
> drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++
> drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++
> include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++
> 5 files changed, 1373 insertions(+)
> create mode 100644 drivers/i3c/i3c-cfs.c
> create mode 100644 drivers/i3c/slave.c
> create mode 100644 include/linux/i3c/slave.h
>
> diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig
> index 30a441506f61c..d5f5ca7cd6a56 100644
> --- a/drivers/i3c/Kconfig
> +++ b/drivers/i3c/Kconfig
> @@ -22,3 +22,29 @@ menuconfig I3C
> if I3C
> source "drivers/i3c/master/Kconfig"
> endif # I3C
> +
> +config I3C_SLAVE

It doesn't look like you follow Kernel naming convention (see coding style).

> + bool "I3C Slave Support"
> + help
> + Support I3C Slave Mode.
> +

Best regards,
Krzysztof