Re: [PATCH 1/1] tty: i3c: add tty over i3c master support

kernel test robot
2023-11-06T20:24:15Z

Hi Frank,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus linus/master v6.6 next-20231106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/tty-i3c-add-tty-over-i3c-master-support/20231019-051407
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20231018211111.3437929-1-Frank.Li%40nxp.com
patch subject: [PATCH 1/1] tty: i3c: add tty over i3c master support
config: microblaze-allyesconfig (https://download.01.org/0day-ci/archive/20231107/202311070330.5mylauLR-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231107/202311070330.5mylauLR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311070330.5mylauLR-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/tty/i3c_tty.c: In function 'tty_i3c_rxwork':
>> drivers/tty/i3c_tty.c:265:26: error: 'struct i3c_priv_xfer' has no member named 'actual_len'
265 | if (xfers.actual_len) {
| ^
drivers/tty/i3c_tty.c:266:82: error: 'struct i3c_priv_xfer' has no member named 'actual_len'
266 | tty_insert_flip_string(&sport->port, sport->buffer, xfers.actual_len);
| ^
>> drivers/tty/i3c_tty.c:271:25: error: implicit declaration of function 'i3c_device_getstatus_format1' [-Werror=implicit-function-declaration]
271 | i3c_device_getstatus_format1(sport->i3cdev, &status);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/tty/i3c_tty.c: At top level:
drivers/tty/i3c_tty.c:400:6: warning: no previous prototype for 'i3c_remove' [-Wmissing-prototypes]
400 | void i3c_remove(struct i3c_device *dev)
| ^~~~~~~~~~
cc1: some warnings being treated as errors

vim +265 drivers/tty/i3c_tty.c

246
247 static void tty_i3c_rxwork(struct work_struct *work)
248 {
249 struct ttyi3c_port *sport = container_of(work, struct ttyi3c_port, rxwork);
250 struct i3c_priv_xfer xfers;
251 int retry = I3C_TTY_RETRY;
252 u16 status = BIT(0);
253
254 do {
255 memset(&xfers, 0, sizeof(xfers));
256 xfers.data.in = sport->buffer;
257 xfers.len = I3C_TTY_TRANS_SIZE;
258 xfers.rnw = 1;
259
260 if (I3C_TTY_RX_STOP & atomic_read(&sport->status))
261 break;
262
263 i3c_device_do_priv_xfers(sport->i3cdev, &xfers, 1);
264
> 265 if (xfers.actual_len) {
266 tty_insert_flip_string(&sport->port, sport->buffer, xfers.actual_len);
267 retry = 20;
268 continue;
269 } else {
270 status = BIT(0);
> 271 i3c_device_getstatus_format1(sport->i3cdev, &status);
272 /*
273 * Target side need some time to fill data into fifo. Target side may not
274 * have hardware update status in real time. Software update status always
275 * need some delays.
276 *
277 * Generally, target side have cicular buffer in memory, it will be moved
278 * into FIFO by CPU or DMA. 'status' just show if cicular buffer empty. But
279 * there are gap, espcially CPU have not response irq to fill FIFO in time.
280 * So xfers.actual will be zero, wait for little time to avoid flood
281 * transfer in i3c bus.
282 */
283 usleep_range(I3C_TTY_YIELD_US, 10 * I3C_TTY_YIELD_US);
284 retry--;
285 }
286
287 } while (retry && (status & BIT(0)));
288
289 tty_flip_buffer_push(&sport->port);
290 }
291

--
0-DAY CI Kernel Test Service