Re: [PATCH 1/1] i3c: master: svc: Improve DAA STOP handle code logic

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Conor Culhane <conor.culhane@silvaco.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-i3c@lists.infradead.org (moderated list:SILVACO I3C
	DUAL-ROLE MASTER), linux-kernel@vger.kernel.org (open list),
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] i3c: master: svc: Improve DAA STOP handle code logic
Date: Mon, 8 Jul 2024 08:53:10 +0200	[thread overview]
Message-ID: <20240708085310.5c5f5521@xps-13> (raw)
In-Reply-To: <20240702223107.403057-1-Frank.Li@nxp.com>

Hi Frank,

Frank.Li@nxp.com wrote on Tue,  2 Jul 2024 18:31:07 -0400:

> The REQUEST_PROC_DAA command behaves differently from other commands.
> Sometimes the hardware can auto emit STOP, but in other conditions, it
> cannot.
> 
> Improves the code logic to better handle these situations.
> 
> Hardware can auto emit STOP only when the following conditions are met:
> - The previous I3C device correctly returns a PID and ACKs an I3C address.
> - A NACK is received when emitting 7E to try to get the next I3C device's
> PID.
> 
> In all other cases, a manual STOP emission is needed.
> 
> The code is changed to emit STOP when break the while loop and 'return 0'
> only when the hardware can auto emit STOP.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Looks sensible to me.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c