Re: [PATCH 2/2] i3c: master: Add Nuvoton npcm845 i3c master driver

Krzysztof Kozlowski
2024-08-01T15:02:52Z

On 01/08/2024 10:42, Markus Elfring wrote:
> …
>> +++ b/drivers/i3c/master/npcm845-i3c-master.c
>> @@ -0,0 +1,2364 @@
> …
>> +static int npcm_i3c_master_do_daa(struct i3c_master_controller *m)
>> +{
> …
>> + int ret, i;
>> +
>> + mutex_lock(&master->lock);
>> + spin_lock_irqsave(&master->req_lock, flags);
> …
>> + npcm_i3c_master_set_sda_skew(master, 0);
>> + spin_unlock_irqrestore(&master->req_lock, flags);
>> + mutex_unlock(&master->lock);
> …
>
> Under which circumstances would you become interested to apply statements
> like the following?


Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
several maintainers ignore Markus' feedback, because it is just a waste
of time.


Best regards,
Krzysztof