Re: [PATCH v3 02/11] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT_BITS

Miquel Raynal
2024-08-26T08:05:49Z

Hi Frank,

Frank.li@nxp.com wrote on Fri, 23 Aug 2024 13:57:31 -0400:

> On Fri, Aug 23, 2024 at 05:55:02PM +0200, Miquel Raynal wrote:
> > Hi Frank,
> >
> > Frank.Li@nxp.com wrote on Mon, 19 Aug 2024 12:01:56 -0400:
> >
> > > Replace the hardcoded value 2, which indicates 2 bits for I3C address
> > > status, with the predefined macro I3C_ADDR_SLOT_BITS.
> >
> > I'm fine with the idea but I don't understand the macro name. You're
> > talking about status bits and yet the macro is named addr_slot?
> >
>
> How about I3C_ADDR_SLOT_STATUS_BITS ?
>
> > > Improve maintainability and extensibility of the code.

I'm a bit flaky on this concept, but let's try that. Perhaps with all
the changes requested (esp. rephrasing) it might become clearer in next
version.

Thanks,
Miquèl