Re: [PATCH v1 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller bindings

Krzysztof Kozlowski
2025-02-12T06:56:31Z

On 11/02/2025 22:39, Rob Herring wrote:
> On Mon, Feb 10, 2025 at 09:42:03PM +0530, Mukesh Kumar Savaliya wrote:
>> Thanks Krzysztof !
>>
>>>
>> Sure. I reviewed other files and seems i should write as below. Please help
>> confirm.
>>
>> compatible:
>> items:
>> - enum:
>> - qcom,sm8550-i3c-master
>> - const: qcom,i3c-master
>
> No, that's even worse. I doubt there is some universal, never changing
> QCom I3C master.
>
>>>>
>>>> SoC name is not required, as this compatible is generic to all the SOCs.
>>>
>>> That's the statement you make. I accept it. I will bookmark this thread
>>> and use it whenever you try to add any future property here (to be
>>> clear: you agree you will not add new properties to fulfill *FUTURE* SoC
>>> differences).
>>>
>> Sorry, i am not saying there won't be any other compatible but i was saying
>> base driver will use "qcom,i3c-master".
>> After checking other files i realized there can be const compatible but
>> other SOC specific can be added as enum. Hope above given way is fine.
>
> AIUI, "geni" is some firmware based multi-protocol serial i/o controller
> and we already have other "geni" bindings. So really, it's probably more
> coupled to firmware versions than SoC versions. If we haven't had
> problems with per SoC quirks with the other geni bindings, then I think
> using the same "geni" here is fine. But we won't be happy if we start
> seeing per SoC quirk properties.

Qualcomm IP blocks are heavily versioned. Sometimes it is version per
SoC (about which you commented enough) but mostly multiple SoCs use same
IP block. Therefore maybe this should be simply versioned according to
firmware/IP block?

Best regards,
Krzysztof