Re: [PATCH v1 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller bindings

Krzysztof Kozlowski
2025-02-05T15:46:11Z

On 05/02/2025 15:31, Mukesh Kumar Savaliya wrote:
> Add device tree bindings for the Qualcomm I3C master controller. This
> includes the necessary documentation and properties required to describe
> the hardware in the device tree.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Use modern terminology, which means:
s/master/whatever else or even nothing/
See other recent bindings and discussions.

>
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> ---
> .../bindings/i3c/qcom,i3c-master.yaml | 57 +++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml
> new file mode 100644
> index 000000000000..ad63ea779fd6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml

Filename matching compatible.

> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/qcom,i3c-master.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm I3C master controller
> +
> +maintainers:
> + - Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> +
> +allOf:
> + - $ref: i3c.yaml#
> +
> +properties:
> + compatible:
> + const: qcom,geni-i3c

No SoC? So to be sure: you claim all future SoCs will be using exactly
the same interface. No new compatibles, no new properties will be added.

> +
> + reg:
> + minItems: 1

Drop

> + maxItems: 2

Drop and instead list and describe items

> +
> + clocks:
> + minItems: 1

Look at other bindings. There is never code like this.

> +
> + clock-names:
> + items:
> + - const: se-clk

Drop clock-names

> +
> + interrupts-extended:
> + minItems: 1
> + maxItems: 3

As well - there is never an interrupts-extended property. Just interrupts.

Also drop constraints and list items.

Best regards,
Krzysztof