Re: [PATCH v1 1/3] i3c: master: svc: add support for Nuvoton npcm845 i3c

Frank Li
2025-02-19T20:44:01Z

On Wed, Feb 19, 2025 at 09:10:17AM +0800, Stanley Chu wrote:
> Nuvoton npcm845 SoC uses the same Silvico IP but an older version.
> Add a new comptaible string to distinguish between different
> hardware versions.

try wrap at 75 chars.

>
> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index d6057d8c7dec..813839498b2b 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1960,6 +1960,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops = {
>
> static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
> { .compatible = "silvaco,i3c-master-v1"},
> + { .compatible = "nuvoton,npcm845-i3c" },

Need update binding doc and cc linux-devicetree mail list.

Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml

binding doc change should be first patch.

Frank

> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
> --
> 2.34.1