From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C3D0C83000 for ; Tue, 24 Jun 2025 00:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i/SA5wJPXLtYhRAtcae6/8kJ/SYBR8nVK9/3obr4VPY=; b=KSLqYULT1HJRrOMj2WoItIw3Hs PA0EAgV+hsKA++Xn0lrX11mIZb8ar/tL1dIyhoY9kjX0llDr1V8lXDBUQGr+MFn03wDXDnE5mpqpL fuN2eFZDexxKDvZy1KFXGL4GkQW7nLEtM9K1dl4q+N6+IoOu0FY4smYlx0po8ByflIZiU+1k2rlhD oHqKnqKZa2HYm5aGl+4nk1Tk7tmxeYA037pkacE4OMbMvdRpqfzmtLL/hRAm7zdQ2tKF/eUivy8QE IizJCooMfDl8QbWSK6NZdlqeds0F9NOwx0Z21ciCYbkjNbZvQLu0qPRN/Yy9RQXBz8hW49sthoicH 4dJqNgDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uTrYu-00000004Emu-0CK3; Tue, 24 Jun 2025 00:30:56 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRYXb-00000007mlY-1TYn for linux-i3c@lists.infradead.org; Tue, 17 Jun 2025 15:48:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A14EE629C1; Tue, 17 Jun 2025 15:48:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AB1AC4CEE7; Tue, 17 Jun 2025 15:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750175282; bh=7xDjTVRfFoRIYUS7gbPNIlQEN7XfsTQ0jalm9e5Wmbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Un+wSOUyk6kW9Yd+vPOAHx3aTj9Mfghr1mrU6K5pZnkrTq6UTBUi7Br8kAWyfYLfZ 5XkCAKNcShHGX34psNKZ2f2tFxcqyDa4DCaEzw7CvVasb3RHWYiCdBxzDw2pN2qz0V UofTVZ1Jyg2G7AELKHFuEYEpm624Hc329n/qgha0/03WJEOtNbmTlG6Hq9QzGY+GG6 uf/ODFRXLEiL7RWwn+/nq8pbmbCs1gob3UXusktMsg5XsBHWsilBKRG8IcTepcXPH+ g9jfsM+V1UzsPidj3ZZfF+wAN5VFqMynyk55IwgdL6T/T0AFuZMYnFIZ4p115zElVV Ojl0Pbgt+GiCQ== Date: Tue, 17 Jun 2025 16:47:58 +0100 From: Conor Dooley To: Jorge Marques Cc: Jorge Marques , Alexandre Belloni , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: i3c: Add adi-i3c-master Message-ID: <20250617-pawing-octane-a983fbf7100d@spud> References: <20250606-adi-i3c-master-v2-0-e68b9aad2630@analog.com> <20250606-adi-i3c-master-v2-1-e68b9aad2630@analog.com> <20250606-sliver-freeing-d01268258c25@spud> MIME-Version: 1.0 In-Reply-To: X-Mailman-Approved-At: Mon, 23 Jun 2025 15:46:42 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4047010250098404654==" Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org --===============4047010250098404654== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ccYjkAPbvZp+RJlR" Content-Disposition: inline --ccYjkAPbvZp+RJlR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2025 at 04:50:43PM +0200, Jorge Marques wrote: > On Fri, Jun 06, 2025 at 05:08:45PM +0100, Conor Dooley wrote: > > On Fri, Jun 06, 2025 at 03:21:02PM +0200, Jorge Marques wrote: > > > Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable= IP > > > core that implements the MIPI I3C Basic controller specification. > > >=20 > > > Signed-off-by: Jorge Marques > > > --- > > > .../devicetree/bindings/i3c/adi,i3c-master.yaml | 63 ++++++++++++= ++++++++++ > > > MAINTAINERS | 5 ++ > > > 2 files changed, 68 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/i3c/adi,i3c-master.yam= l b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml > > > new file mode 100644 > > > index 0000000000000000000000000000000000000000..e7fae394ad8fd4143eb1f= ffb9591a30a2d6cc6ac > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml > > > @@ -0,0 +1,63 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/i3c/adi,i3c-master.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analog Devices I3C Controller > > > + > > > +description: | > > > + The ADI I3C controller implements a subset of the I3C-basic specif= ication to > > > + interface I3C and I2C peripherals [1]. > > > + > > > + [1] https://analogdevicesinc.github.io/hdl/library/i3c_controller > > > + > > > +maintainers: > > > + - Jorge Marques > > > + > > > +properties: > > > + compatible: > > > + const: adi,i3c-master > >=20 > Hi Conor, > > Seeing this with no versioning info is pretty suspect. > > The adi spi, pwm, axi-dmac etc all have versioning info, please try to > > emulate that. > >=20 > > Otherwise, I think this is okay. > >=20 > > Cheers, > > Conor. > >=20 > The driver checks the IP version via register access, for the other adi > ips, the -x.00.a suffix was never updated. For example, the axi-dmac > current IP version is v4.5.64 while the compatible still is 1.00.a and > there is a mention of v4.3.a in the binding. It is unclear whether > suffixing it with "-1.00.a" would be useful, or if the time comes call > the new "adi,i3c-master-2". >=20 > Do you still think it is necessary? I do, yes. In the other cases, if a new version comes out that has some sort of meaningful difference a new compatible can be added. Until then, using the -1.00.a one is okay. --ccYjkAPbvZp+RJlR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaFGOLgAKCRB4tDGHoIJi 0iMzAQDPAR4PK0PcUd5lSc02GuSVxCnkgzmctV+hB+9EvRrrWwD/TozQwUHyg8XP QHwTVjYIS0ELbPAh9ts0B1MhPgjw1Qw= =CxyJ -----END PGP SIGNATURE----- --ccYjkAPbvZp+RJlR-- --===============4047010250098404654== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c --===============4047010250098404654==--