From: Jorge Marques <jorge.marques@analog.com>
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Przemysław Gaj" <pgaj@cadence.com>
Cc: <linux-i3c@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
"Jorge Marques" <jorge.marques@analog.com>
Subject: [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl
Date: Fri, 20 Jun 2025 18:54:59 +0200 [thread overview]
Message-ID: <20250620-i3c-writesl-readsl-v1-1-e0aa1c014dff@analog.com> (raw)
In-Reply-To: <20250620-i3c-writesl-readsl-v1-0-e0aa1c014dff@analog.com>
The i3c abstraction excepts u8 buffers, but some controllers have a bus
width of 32-bits and don't support flagging valid bytes, so it is
required to read/write long words and to use memcpy on the remainder of
the number of bytes by 32-bits to not write/read outside the buffer
bounds.
Signed-off-by: Jorge Marques <jorge.marques@analog.com>
---
include/linux/i3c/master.h | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
index c67922ece617d6320c0c7e4838c2e7edda8c19f5..11401f2acb42e4d3a60df33b7c794d8a0360cdc2 100644
--- a/include/linux/i3c/master.h
+++ b/include/linux/i3c/master.h
@@ -674,6 +674,42 @@ i3c_master_get_bus(struct i3c_master_controller *master)
return &master->bus;
}
+/**
+ * i3c_master_writesl- Write bytes to long memory region from byte array
+ * @addr: Register to write to
+ * @bytes: Pointer to the data bytes to write
+ * @nbytes: Number of bytes to write
+ */
+static inline void i3c_master_writesl(void __iomem *addr, const u8 *bytes,
+ int nbytes)
+{
+writesl(addr, bytes, nbytes / 4);
+ if (nbytes & 3) {
+ u32 tmp = 0;
+
+ memcpy(&tmp, bytes + (nbytes & ~3), nbytes & 3);
+ writel(tmp, addr);
+ }
+}
+
+/**
+ * i3c_master_readsl - Read bytes from long memory region to byte array
+ * @addr: Register to read from
+ * @bytes: Pointer to the buffer to store read bytes
+ * @nbytes: Number of bytes to read
+ */
+static inline void i3c_master_readsl(const void __iomem *addr, u8 *bytes,
+ int nbytes)
+{
+readsl(addr, bytes, nbytes / 4);
+ if (nbytes & 3) {
+ u32 tmp;
+
+ tmp = readl(addr);
+ memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
+ }
+}
+
struct i3c_generic_ibi_pool;
struct i3c_generic_ibi_pool *
--
2.49.0
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-06-20 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 16:54 [PATCH 0/3] Add helper methods i3c_master_writesl and i3c_master_readsl Jorge Marques
2025-06-20 16:54 ` Jorge Marques [this message]
2025-06-20 18:41 ` [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl Frank Li
2025-06-22 8:43 ` Jorge Marques
2025-06-20 21:15 ` Wolfram Sang
2025-06-22 8:31 ` Jorge Marques
2025-06-20 16:55 ` [PATCH 2/3] i3c: master: cdns: Use i3c_master_writesl and i3c_master_readsl Jorge Marques
2025-06-20 18:46 ` Frank Li
2025-06-20 16:55 ` [PATCH 3/3] i3c: master: dw: " Jorge Marques
2025-06-20 18:48 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620-i3c-writesl-readsl-v1-1-e0aa1c014dff@analog.com \
--to=jorge.marques@analog.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgaj@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).