From: Jorge Marques <jorge.marques@analog.com>
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Przemysław Gaj" <pgaj@cadence.com>
Cc: <linux-i3c@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Jorge Marques <jorge.marques@analog.com>
Subject: [PATCH 3/3] i3c: master: dw: Use i3c_master_writesl and i3c_master_readsl
Date: Fri, 20 Jun 2025 18:55:01 +0200 [thread overview]
Message-ID: <20250620-i3c-writesl-readsl-v1-3-e0aa1c014dff@analog.com> (raw)
In-Reply-To: <20250620-i3c-writesl-readsl-v1-0-e0aa1c014dff@analog.com>
Use the inline write/read methods common to controllers that have a
bus width of 32-bits.
Signed-off-by: Jorge Marques <jorge.marques@analog.com>
---
drivers/i3c/master/dw-i3c-master.c | 24 +++---------------------
1 file changed, 3 insertions(+), 21 deletions(-)
diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 611c22b72c1572ddf717c8ad473e44a3b8fcceaf..eb1346409829dc64cdd1d738e9870993d38bbb0f 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -336,37 +336,19 @@ static int dw_i3c_master_get_free_pos(struct dw_i3c_master *master)
static void dw_i3c_master_wr_tx_fifo(struct dw_i3c_master *master,
const u8 *bytes, int nbytes)
{
- writesl(master->regs + RX_TX_DATA_PORT, bytes, nbytes / 4);
- if (nbytes & 3) {
- u32 tmp = 0;
-
- memcpy(&tmp, bytes + (nbytes & ~3), nbytes & 3);
- writesl(master->regs + RX_TX_DATA_PORT, &tmp, 1);
- }
-}
-
-static void dw_i3c_master_read_fifo(struct dw_i3c_master *master,
- int reg, u8 *bytes, int nbytes)
-{
- readsl(master->regs + reg, bytes, nbytes / 4);
- if (nbytes & 3) {
- u32 tmp;
-
- readsl(master->regs + reg, &tmp, 1);
- memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
- }
+ i3c_master_writesl(master->regs + RX_TX_DATA_PORT, bytes, nbytes);
}
static void dw_i3c_master_read_rx_fifo(struct dw_i3c_master *master,
u8 *bytes, int nbytes)
{
- return dw_i3c_master_read_fifo(master, RX_TX_DATA_PORT, bytes, nbytes);
+ i3c_master_readsl(master + RX_TX_DATA_PORT, bytes, nbytes);
}
static void dw_i3c_master_read_ibi_fifo(struct dw_i3c_master *master,
u8 *bytes, int nbytes)
{
- return dw_i3c_master_read_fifo(master, IBI_QUEUE_STATUS, bytes, nbytes);
+ i3c_master_readsl(master + IBI_QUEUE_STATUS, bytes, nbytes);
}
static struct dw_i3c_xfer *
--
2.49.0
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-06-20 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 16:54 [PATCH 0/3] Add helper methods i3c_master_writesl and i3c_master_readsl Jorge Marques
2025-06-20 16:54 ` [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl Jorge Marques
2025-06-20 18:41 ` Frank Li
2025-06-22 8:43 ` Jorge Marques
2025-06-20 21:15 ` Wolfram Sang
2025-06-22 8:31 ` Jorge Marques
2025-06-20 16:55 ` [PATCH 2/3] i3c: master: cdns: Use i3c_master_writesl and i3c_master_readsl Jorge Marques
2025-06-20 18:46 ` Frank Li
2025-06-20 16:55 ` Jorge Marques [this message]
2025-06-20 18:48 ` [PATCH 3/3] i3c: master: dw: " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620-i3c-writesl-readsl-v1-3-e0aa1c014dff@analog.com \
--to=jorge.marques@analog.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgaj@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).