Re: [PATCH V2 2/2] i3c: master: Add AMD I3C bus controller driver

Alexandre Belloni
2025-09-02T00:52:29Z

On 29/08/2025 22:43:27+0530, Manikanta Guntupalli wrote:
> +static void xi3c_master_reset_fifos(struct xi3c_master *master)
> +{
> + u32 data;
> +
> + /* Reset fifos */
> + data = readl(master->membase + XI3C_RESET_OFFSET);
> + data |= XI3C_FIFOS_RST_MASK;
> + writel(data, master->membase + XI3C_RESET_OFFSET);
> + udelay(10);

As pointed out by checkpatch:
usleep_range is preferred over udelay, I guess it would be fine in this
function.

> + data &= ~XI3C_FIFOS_RST_MASK;
> + writel(data, master->membase + XI3C_RESET_OFFSET);
> + udelay(10);
> +}
> +

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering