From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Frank Li <Frank.li@nxp.com>, linux-i3c@lists.infradead.org
Subject: Re: [PATCH 5/5] i3c: mipi-i3c-hci: Convert remaining DBG() prints to dev_dbg()
Date: Mon, 15 Sep 2025 10:14:55 +0200 [thread overview]
Message-ID: <20250915081455ad63f5d9@mail.local> (raw)
In-Reply-To: <b5cd2d90-9b51-4760-9b2f-3505a6b02f73@linux.intel.com>
On 15/09/2025 11:06:54+0300, Jarkko Nikula wrote:
> On 9/12/25 5:31 PM, Frank Li wrote:
> > On Wed, Aug 27, 2025 at 01:30:09PM +0300, Jarkko Nikula wrote:
> > > Get rid of local DBG() macro and convert remaining debug prints to
> > > dev_dbg() which can be controlled without code recompile when kernel is
> > > built with dynamic debug support.
> > >
> > > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > > ---
> > > drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 9 ++-
> > > drivers/i3c/master/mipi-i3c-hci/cmd_v2.c | 7 ++-
> > > drivers/i3c/master/mipi-i3c-hci/core.c | 16 +++---
> > > drivers/i3c/master/mipi-i3c-hci/dma.c | 15 +++--
> > > drivers/i3c/master/mipi-i3c-hci/ext_caps.c | 11 ++--
> > > drivers/i3c/master/mipi-i3c-hci/hci.h | 3 -
> > > drivers/i3c/master/mipi-i3c-hci/pio.c | 66 +++++++++++++---------
> > > 7 files changed, 72 insertions(+), 55 deletions(-)
> > ...
> > > -#define DBG(x, ...) pr_devel("%s: " x "\n", __func__, ##__VA_ARGS__)
> > > -
> > > /* 32-bit word aware bit and mask macros */
> > > #define W0_MASK(h, l) GENMASK((h) - 0, (l) - 0)
> > > #define W1_MASK(h, l) GENMASK((h) - 32, (l) - 32)
> > > diff --git a/drivers/i3c/master/mipi-i3c-hci/pio.c b/drivers/i3c/master/mipi-i3c-hci/pio.c
> > > index cde883137bc7..01e7d2833301 100644
> > > --- a/drivers/i3c/master/mipi-i3c-hci/pio.c
> > > +++ b/drivers/i3c/master/mipi-i3c-hci/pio.c
> > > @@ -213,7 +213,7 @@ static void hci_pio_cleanup(struct i3c_hci *hci)
> > > pio_reg_write(INTR_SIGNAL_ENABLE, 0x0);
> > >
> > > if (pio) {
> > > - DBG("status = %#x/%#x",
> > > + dev_dbg(&hci->master.dev, "status = %#x/%#x",
> > > pio_reg_read(INTR_STATUS), pio_reg_read(INTR_SIGNAL_ENABLE));
> >
> > fix pio_reg_read() align to (
> >
> Ah, this slipped my eyes. I can send a follow up patch giving kudos to you
> since this patch was now applied or leave it as it.
I fixed it while applying.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-09-15 8:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 10:30 [PATCH 0/5] i3c: mipi-i3c-hci: Convert DBG() prints to dev_dbg() Jarkko Nikula
2025-08-27 10:30 ` [PATCH 1/5] i3c: mipi-i3c-hci: Change interrupt status " Jarkko Nikula
2025-09-12 14:22 ` Frank Li
2025-08-27 10:30 ` [PATCH 2/5] i3c: mipi-i3c-hci: Remove nonexistent ring interrupt Jarkko Nikula
2025-09-12 14:23 ` Frank Li
2025-08-27 10:30 ` [PATCH 3/5] i3c: mipi-i3c-hci: Uniform ring number printouts Jarkko Nikula
2025-09-12 14:23 ` Frank Li
2025-08-27 10:30 ` [PATCH 4/5] i3c: mipi-i3c-hci: Remove function enter DBG() printouts Jarkko Nikula
2025-09-12 14:27 ` Frank Li
2025-08-27 10:30 ` [PATCH 5/5] i3c: mipi-i3c-hci: Convert remaining DBG() prints to dev_dbg() Jarkko Nikula
2025-09-12 14:31 ` Frank Li
2025-09-15 8:06 ` Jarkko Nikula
2025-09-15 8:14 ` Alexandre Belloni [this message]
2025-09-15 8:18 ` Jarkko Nikula
2025-09-12 7:25 ` [PATCH 0/5] i3c: mipi-i3c-hci: Convert " Jarkko Nikula
2025-09-14 20:30 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915081455ad63f5d9@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.li@nxp.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).