From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: adrianhoyin.ng@altera.com
Cc: Frank.Li@nxp.com, wsa+renesas@sang-engineering.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dinguyen@kernel.org, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] i3c: dw: Add support for Device NACK Retry count
Date: Thu, 6 Nov 2025 23:10:48 +0100 [thread overview]
Message-ID: <20251106221048367d654a@mail.local> (raw)
In-Reply-To: <cover.1762245890.git.adrianhoyin.ng@altera.com>
On 04/11/2025 16:51:07+0800, adrianhoyin.ng@altera.com wrote:
> From: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
>
> This series adds support for configuring the Device NACK Retry count
> in the Synopsys DesignWare I3C master controller and enables the
> corresponding property in the Altera Agilex5 device tree.
>
> Some I3C slave devices may temporarily NACK transactions when they are
> busy or not ready to respond. To enhance bus reliability, the DesignWare
> I3C controller supports a programmable retry mechanism that automatically
> reissues NACKed transactions. This series introduces the
> snps,dev-nack-retry-cnt device tree property to configure this retry
> count. The value is written into the Device Address Table (DAT) entry for
> each I3C device, enabling fine-grained control of retry behavior.
>
As Frank explained, this needs to be a per device sysfs file because
this is definitively policy and not HW related. This file should only be
visible when the bus supports retrying.
Don't forget to add documentation in ABI/testing/sysfs-bus-i3c
> This series also fixes an issue where existing DAT entries could be
> overwritten when the driver restores device addresses. Update
> dw_i3c_master_restore_addrs to preserve existing bits in each
> DAT entry when restoring addresses.
>
> Adrian Ng Ho Yin (4):
> dt-bindings: i3c: Add snps,dev-nack-retry-cnt property to Synopsys I3C
> master
> arm64: dts: intel: agilex5: Add snps,dev-nack-retry-cnt property for
> I3C controllers
> i3c: dw: Add support for Device NACK Retry count
> i3c: dw: Preserve DAT entry bits when restoring addresses
>
> .../bindings/i3c/snps,dw-i3c-master.yaml | 8 ++++
> .../arm64/boot/dts/intel/socfpga_agilex5.dtsi | 2 +
> drivers/i3c/master/dw-i3c-master.c | 40 ++++++++++++++++++-
> drivers/i3c/master/dw-i3c-master.h | 1 +
> 4 files changed, 49 insertions(+), 2 deletions(-)
>
> --
> 2.49.GIT
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2025-11-06 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 8:51 [PATCH 0/4] i3c: dw: Add support for Device NACK Retry count adrianhoyin.ng
2025-11-04 8:51 ` [PATCH 1/4] dt-bindings: i3c: Add snps,dev-nack-retry-cnt property to Synopsys I3C master adrianhoyin.ng
2025-11-04 9:02 ` Krzysztof Kozlowski
2025-11-04 19:25 ` Frank Li
2025-11-04 8:51 ` [PATCH 2/4] arm64: dts: intel: agilex5: Add snps,dev-nack-retry-cnt property for I3C controllers adrianhoyin.ng
2025-11-04 8:51 ` [PATCH 3/4] i3c: dw: Add support for Device NACK Retry count adrianhoyin.ng
2025-11-04 19:28 ` Frank Li
2025-11-04 8:51 ` [PATCH 4/4] i3c: dw: Preserve DAT entry bits when restoring addresses adrianhoyin.ng
2025-11-06 22:10 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106221048367d654a@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=adrianhoyin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).