From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Marco Crivellari <marco.crivellari@suse.com>,
linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] i3c: master: add WQ_PERCPU to alloc_workqueue users
Date: Mon, 10 Nov 2025 23:56:07 +0100 [thread overview]
Message-ID: <202511102256074aa37109@mail.local> (raw)
In-Reply-To: <aRIaQOQkbPOFpJM+@lizhi-Precision-Tower-5810>
On 10/11/2025 12:00:48-0500, Frank Li wrote:
> On Fri, Nov 07, 2025 at 11:28:30PM +0100, Sebastian Andrzej Siewior wrote:
> > On 2025-11-07 16:00:06 [-0500], Frank Li wrote:
> > > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> > > > index d946db75df70..519b98c37ac7 100644
> > > > --- a/drivers/i3c/master.c
> > > > +++ b/drivers/i3c/master.c
> > > > @@ -2925,7 +2925,7 @@ int i3c_master_register(struct i3c_master_controller *master,
> > > > if (ret)
> > > > goto err_put_dev;
> > > >
> > > > - master->wq = alloc_workqueue("%s", 0, 0, dev_name(parent));
> > > > + master->wq = alloc_workqueue("%s", WQ_PERCPU, 0, dev_name(parent));
> > >
> > > Maybe off topic, I think it is not neccesary to create wq for IBI at all.
> > > it can directly use system_bh_wq, or other wq.
> >
> > Do you really meant system_bh_wq or would system_unbound_wq do the job?
> > The _bh_ one would imply softirq usage, I don't think you want that.
>
> My major means is that not neccessary to alloc a work queue for IBI. Use
> one of system predefined should be enough. system_unbound_wq is good
> candidate.
>
I don't agree because you may want to be able to prioritize handling
IBIs vs other work so I believe it makes sense to have a separate
workqueue.
> Your change is also good, let's wait for more reviewer's comments.
>
> Frank
>
> >
> > > Frank
> >
> > Sebastian
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2025-11-10 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 13:29 [PATCH] i3c: master: add WQ_PERCPU to alloc_workqueue users Marco Crivellari
2025-11-07 21:00 ` Frank Li
2025-11-07 22:28 ` Sebastian Andrzej Siewior
2025-11-10 17:00 ` Frank Li
2025-11-10 22:56 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511102256074aa37109@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.li@nxp.com \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).