linux-i3c.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org
Subject: [PATCH 07/13] i3c: mipi-i3c-hci-pci: Factor out intel_reset()
Date: Wed, 12 Nov 2025 12:03:33 +0200	[thread overview]
Message-ID: <20251112100339.51726-8-adrian.hunter@intel.com> (raw)
In-Reply-To: <20251112100339.51726-1-adrian.hunter@intel.com>

For neatness, factor out intel_reset().

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 .../master/mipi-i3c-hci/mipi-i3c-hci-pci.c    | 26 ++++++++++++-------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
index 003ae61e9f6c..b3b6b6f43af2 100644
--- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
+++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
@@ -34,18 +34,9 @@ static void __iomem *intel_priv(struct pci_dev *pci)
 	return devm_ioremap(&pci->dev, base + INTEL_PRIV_OFFSET, INTEL_PRIV_SIZE);
 }
 
-static int intel_init(struct pci_dev *pci)
+static void intel_reset(void __iomem *priv)
 {
-	void __iomem *priv = intel_priv(pci);
 	u32 reg;
-	int ret;
-
-	if (!priv)
-		return -ENOMEM;
-
-	ret = dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
-	if (ret)
-		return ret;
 
 	/* Assert reset, wait for completion and release reset */
 	writel(0, priv + INTEL_RESETS);
@@ -53,6 +44,21 @@ static int intel_init(struct pci_dev *pci)
 			   reg & INTEL_RESETS_RESET_DONE, 0,
 			   INTEL_RESETS_TIMEOUT_US);
 	writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
+}
+
+static int intel_init(struct pci_dev *pci)
+{
+	void __iomem *priv = intel_priv(pci);
+	int ret;
+
+	if (!priv)
+		return -ENOMEM;
+
+	ret = dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
+	if (ret)
+		return ret;
+
+	intel_reset(priv);
 
 	return 0;
 }
-- 
2.51.0


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  parent reply	other threads:[~2025-11-12 10:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 10:03 [PATCH 00/13] i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers Adrian Hunter
2025-11-12 10:03 ` [PATCH 01/13] i3c: mipi-i3c-hci-pci: Set 64-bit DMA mask " Adrian Hunter
2025-11-12 15:51   ` Frank Li
2025-11-12 10:03 ` [PATCH 02/13] i3c: mipi-i3c-hci-pci: Move all Intel-related definitions together Adrian Hunter
2025-11-12 15:53   ` Frank Li
2025-11-13 12:58     ` Adrian Hunter
2025-11-12 10:03 ` [PATCH 03/13] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers Adrian Hunter
2025-11-12 15:57   ` Frank Li
2025-11-13 13:01     ` Adrian Hunter
2025-11-13 16:19       ` Frank Li
2025-11-13 16:57         ` Adrian Hunter
2025-11-13 17:17           ` Frank Li
2025-11-12 10:03 ` [PATCH 04/13] i3c: mipi-i3c-hci-pci: Use readl_poll_timeout() Adrian Hunter
2025-11-12 15:59   ` Frank Li
2025-11-14 16:02     ` Alexandre Belloni
2025-11-14 16:43       ` Frank Li
2025-11-14 17:20         ` Alexandre Belloni
2025-11-12 10:03 ` [PATCH 05/13] i3c: mipi-i3c-hci-pci: Constify driver data Adrian Hunter
2025-11-12 16:01   ` Frank Li
2025-11-12 10:03 ` [PATCH 06/13] i3c: mipi-i3c-hci-pci: Factor out private registers ioremapping Adrian Hunter
2025-11-12 16:09   ` Frank Li
2025-11-13 13:02     ` Adrian Hunter
2025-11-12 10:03 ` Adrian Hunter [this message]
2025-11-12 16:13   ` [PATCH 07/13] i3c: mipi-i3c-hci-pci: Factor out intel_reset() Frank Li
2025-11-12 10:03 ` [PATCH 08/13] i3c: mipi-i3c-hci-pci: Allocate a structure for mipi_i3c_hci_pci device information Adrian Hunter
2025-11-12 16:41   ` Frank Li
2025-11-12 19:25     ` Adrian Hunter
2025-11-12 20:17       ` Frank Li
2025-11-13 13:15         ` Adrian Hunter
2025-11-13 16:25           ` Frank Li
2025-11-12 10:03 ` [PATCH 09/13] i3c: mipi-i3c-hci-pci: Change callback parameter Adrian Hunter
2025-11-12 10:03 ` [PATCH 10/13] i3c: mipi-i3c-hci-pci: Add exit callback Adrian Hunter
2025-11-12 10:03 ` [PATCH 11/13] i3c: mipi-i3c-hci-pci: Allocate a structure for Intel controller information Adrian Hunter
2025-11-12 10:03 ` [PATCH 12/13] i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers Adrian Hunter
2025-11-12 10:03 ` [PATCH 13/13] i3c: mipi-i3c-hci-pci: Set d3cold_delay to 0 " Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112100339.51726-8-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-i3c@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).