From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org
Subject: [PATCH V2 03/13] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers
Date: Fri, 14 Nov 2025 20:13:46 +0200 [thread overview]
Message-ID: <20251114181356.66515-4-adrian.hunter@intel.com> (raw)
In-Reply-To: <20251114181356.66515-1-adrian.hunter@intel.com>
Rename some Intel-related identifiers to ensure Intel-related identifiers
begin "intel_" or INTEL_, and for brevity removing purposeless "PRIV" in
preparation to add more register definitions.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
Changes in V2:
Rename 'intel_init' to 'intel_i3c_init'
More explanation in commit message
.../i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
index 3d854cee05df..d434e2962740 100644
--- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
+++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
@@ -21,11 +21,11 @@ static DEFINE_IDA(mipi_i3c_hci_pci_ida);
#define INTEL_PRIV_OFFSET 0x2b0
#define INTEL_PRIV_SIZE 0x28
-#define INTEL_PRIV_RESETS 0x04
-#define INTEL_PRIV_RESETS_RESET BIT(0)
-#define INTEL_PRIV_RESETS_RESET_DONE BIT(1)
+#define INTEL_RESETS 0x04
+#define INTEL_RESETS_RESET BIT(0)
+#define INTEL_RESETS_RESET_DONE BIT(1)
-static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
+static int intel_i3c_init(struct pci_dev *pci)
{
unsigned long timeout;
void __iomem *priv;
@@ -39,21 +39,21 @@ static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
/* Assert reset, wait for completion and release reset */
- writel(0, priv + INTEL_PRIV_RESETS);
+ writel(0, priv + INTEL_RESETS);
timeout = jiffies + msecs_to_jiffies(10);
- while (!(readl(priv + INTEL_PRIV_RESETS) &
- INTEL_PRIV_RESETS_RESET_DONE)) {
+ while (!(readl(priv + INTEL_RESETS) &
+ INTEL_RESETS_RESET_DONE)) {
if (time_after(jiffies, timeout))
break;
cpu_relax();
}
- writel(INTEL_PRIV_RESETS_RESET, priv + INTEL_PRIV_RESETS);
+ writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
return 0;
}
static struct mipi_i3c_hci_pci_info intel_info = {
- .init = mipi_i3c_hci_pci_intel_init,
+ .init = intel_i3c_init,
};
static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
--
2.51.0
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-11-14 18:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 18:13 [PATCH V2 00/13] i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers Adrian Hunter
2025-11-14 18:13 ` [PATCH V2 01/13] i3c: mipi-i3c-hci-pci: Set 64-bit DMA mask " Adrian Hunter
2025-11-14 19:43 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 02/13] i3c: mipi-i3c-hci-pci: Move all Intel-related definitions together Adrian Hunter
2025-11-14 18:13 ` Adrian Hunter [this message]
2025-11-14 19:44 ` [PATCH V2 03/13] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers Frank Li
2025-11-14 18:13 ` [PATCH V2 04/13] i3c: mipi-i3c-hci-pci: Use readl_poll_timeout() Adrian Hunter
2025-11-14 19:44 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 05/13] i3c: mipi-i3c-hci-pci: Constify driver data Adrian Hunter
2025-11-14 18:13 ` [PATCH V2 06/13] i3c: mipi-i3c-hci-pci: Factor out private registers ioremapping Adrian Hunter
2025-11-14 18:13 ` [PATCH V2 07/13] i3c: mipi-i3c-hci-pci: Factor out intel_reset() Adrian Hunter
2025-11-14 19:46 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 08/13] i3c: mipi-i3c-hci-pci: Allocate a structure for mipi_i3c_hci_pci device information Adrian Hunter
2025-11-14 18:13 ` [PATCH V2 09/13] i3c: mipi-i3c-hci-pci: Change callback parameter Adrian Hunter
2025-11-14 19:49 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 10/13] i3c: mipi-i3c-hci-pci: Add exit callback Adrian Hunter
2025-11-14 19:52 ` Frank Li
2025-11-14 19:59 ` Adrian Hunter
2025-11-17 15:33 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 11/13] i3c: mipi-i3c-hci-pci: Allocate a structure for Intel controller information Adrian Hunter
2025-11-14 20:11 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 12/13] i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers Adrian Hunter
2025-11-14 20:09 ` Frank Li
2025-11-17 11:36 ` Adrian Hunter
2025-11-17 15:59 ` Frank Li
2025-11-17 17:47 ` Adrian Hunter
2025-11-17 17:54 ` Frank Li
2025-11-17 18:09 ` Adrian Hunter
2025-11-17 18:56 ` Frank Li
2025-11-17 19:07 ` Adrian Hunter
2025-11-17 19:35 ` Frank Li
2025-11-14 18:13 ` [PATCH V2 13/13] i3c: mipi-i3c-hci-pci: Set d3cold_delay to 0 " Adrian Hunter
2025-11-14 20:10 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114181356.66515-4-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).