From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org
Subject: [PATCH V4 09/12] i3c: mipi-i3c-hci-pci: Change callback parameter
Date: Tue, 18 Nov 2025 18:44:50 +0200 [thread overview]
Message-ID: <20251118164453.55532-10-adrian.hunter@intel.com> (raw)
In-Reply-To: <20251118164453.55532-1-adrian.hunter@intel.com>
Prepare to add more callbacks in mipi_i3c_hci_pci_info. Change ->init()
callback parameter from PCI device pointer to mipi_i3c_hci_pci_info device
pointer.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
Changes in V4:
Add Frank's Rev'd-by
Changes in V3:
Improve commit message.
Changes in V2:
Re-based
drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
index 8936e50eddf7..7bfb9fe337b6 100644
--- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
+++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
@@ -15,11 +15,12 @@
#include <linux/platform_device.h>
struct mipi_i3c_hci_pci {
+ struct pci_dev *pci;
struct platform_device *pdev;
};
struct mipi_i3c_hci_pci_info {
- int (*init)(struct pci_dev *pci);
+ int (*init)(struct mipi_i3c_hci_pci *hci);
};
static DEFINE_IDA(mipi_i3c_hci_pci_ida);
@@ -50,14 +51,14 @@ static void __iomem *intel_priv(struct pci_dev *pci)
return devm_ioremap(&pci->dev, base + INTEL_PRIV_OFFSET, INTEL_PRIV_SIZE);
}
-static int intel_i3c_init(struct pci_dev *pci)
+static int intel_i3c_init(struct mipi_i3c_hci_pci *hci)
{
- void __iomem *priv = intel_priv(pci);
+ void __iomem *priv = intel_priv(hci->pci);
if (!priv)
return -ENOMEM;
- dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
+ dma_set_mask_and_coherent(&hci->pci->dev, DMA_BIT_MASK(64));
intel_reset(priv);
@@ -80,6 +81,8 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
if (!hci)
return -ENOMEM;
+ hci->pci = pci;
+
ret = pcim_enable_device(pci);
if (ret)
return ret;
@@ -113,7 +116,7 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
info = (const struct mipi_i3c_hci_pci_info *)id->driver_data;
if (info && info->init) {
- ret = info->init(pci);
+ ret = info->init(hci);
if (ret)
goto err;
}
--
2.51.0
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-11-18 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 16:44 [PATCH V4 00/12] i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 01/12] i3c: mipi-i3c-hci-pci: Set 64-bit DMA mask " Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 02/12] i3c: mipi-i3c-hci-pci: Move all Intel-related definitions together Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 03/12] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 04/12] i3c: mipi-i3c-hci-pci: Use readl_poll_timeout() Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 05/12] i3c: mipi-i3c-hci-pci: Constify driver data Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 06/12] i3c: mipi-i3c-hci-pci: Factor out private registers ioremapping Adrian Hunter
2025-11-18 16:50 ` Frank Li
2025-11-18 16:44 ` [PATCH V4 07/12] i3c: mipi-i3c-hci-pci: Factor out intel_reset() Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 08/12] i3c: mipi-i3c-hci-pci: Allocate a structure for mipi_i3c_hci_pci device information Adrian Hunter
2025-11-18 16:44 ` Adrian Hunter [this message]
2025-11-18 16:44 ` [PATCH V4 10/12] i3c: mipi-i3c-hci-pci: Add exit callback Adrian Hunter
2025-11-18 16:44 ` [PATCH V4 11/12] i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers Adrian Hunter
2025-11-18 16:49 ` Frank Li
2025-11-18 16:44 ` [PATCH V4 12/12] i3c: mipi-i3c-hci-pci: Set d3cold_delay to 0 " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118164453.55532-10-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).