Re: [PATCH 03/17] i3c: master: Update hot-join flag only on success

Frank Li
2025-12-19T16:24:02Z

On Fri, Dec 19, 2025 at 04:45:20PM +0200, Adrian Hunter wrote:
> To prevent inconsistent state when an error occurs, ensure the hot-join
> flag is updated only when enabling or disabling hot-join succeeds.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---

It should be bug fix. put fix tag.

Frank

> drivers/i3c/master.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 7f606c871648..e6384bffd4ae 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -618,7 +618,8 @@ static int i3c_set_hotjoin(struct i3c_master_controller *master, bool enable)
> else
> ret = master->ops->disable_hotjoin(master);
>
> - master->hotjoin = enable;
> + if (!ret)
> + master->hotjoin = enable;
>
> i3c_bus_normaluse_unlock(&master->bus);
>
> --
> 2.51.0
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c