From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Frank Li <Frank.li@nxp.com>,
Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
wsa+renesas <wsa+renesas@sang-engineering.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"magnus.damm" <magnus.damm@gmail.com>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/4] i3c: renesas: Switch to clk_bulk API and store clocks in private data
Date: Tue, 6 Jan 2026 16:54:23 +0100 [thread overview]
Message-ID: <20260106155423992035a6@mail.local> (raw)
In-Reply-To: <TYCPR01MB11332395B91D672D6BD46CECD8687A@TYCPR01MB11332.jpnprd01.prod.outlook.com>
On 06/01/2026 15:41:10+0000, Biju Das wrote:
> > This is just more flexiable for clk schema. If your schema is simple enough check num_clks >
> > RENESAS_I3C_TCLK_IDX should be enough.
>
> For avoiding crash that check is sufficient, but as you said wrong dtb like crash
> can also lead to non-functional i3c device
>
> Eg:
>
> From bindings, we expect the below entries in DTS for RZ/G3S
>
> "pclk", "tclk" for RZ/G3S
>
> But user mistakenly just added "pclk", that will lead to kernel crash
>
> Or
>
> Swap the clocks
>
> "tclk", "pclk" this will lead to non-functional i3c device
>
> On both cases, user ignored DT binding check warnings.
>
> As you said crash is fatal, maybe stick with just num_clks > RENESAS_I3C_TCLK_IDX
Yes, this is enough
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-01-06 15:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 10:49 [PATCH v4 0/4] i3c: renesas: Add suspend/resume support Tommaso Merciai
2026-01-05 10:49 ` [PATCH v4 1/4] i3c: renesas: Switch to clk_bulk API and store clocks in private data Tommaso Merciai
2026-01-05 17:11 ` Frank Li
2026-01-05 18:06 ` Biju Das
2026-01-06 14:49 ` Frank Li
2026-01-06 15:01 ` Biju Das
2026-01-06 15:17 ` Frank Li
2026-01-06 15:41 ` Biju Das
2026-01-06 15:54 ` Alexandre Belloni [this message]
2026-01-05 10:50 ` [PATCH v4 2/4] i3c: renesas: Store clock rate and reset controls in struct renesas_i3c Tommaso Merciai
2026-01-05 10:53 ` Biju Das
2026-01-05 11:15 ` Tommaso Merciai
2026-01-05 10:50 ` [PATCH v4 3/4] i3c: renesas: Factor out hardware initialization to separate function Tommaso Merciai
2026-01-05 10:50 ` [PATCH v4 4/4] i3c: renesas: Add suspend/resume support Tommaso Merciai
2026-01-05 17:15 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106155423992035a6@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.li@nxp.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox