public inbox for linux-i3c@lists.infradead.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Aniket <aniketmaurya@google.com>,
	linux-i3c@lists.infradead.org
Subject: [PATCH V2 04/20] i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked()
Date: Thu,  8 Jan 2026 10:05:42 +0200	[thread overview]
Message-ID: <20260108080558.21767-5-adrian.hunter@intel.com> (raw)
In-Reply-To: <20260108080558.21767-1-adrian.hunter@intel.com>

IBI disable failures are not indicative of a software bug, so using
WARN_ON() is not appropriate.  Replace these warnings with dev_err().

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---


Changes in V2:

	Add Frank's Rev'd-by


 drivers/i3c/master.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index e6384bffd4ae..ff6cbc044787 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -3113,8 +3113,11 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *dev)
 	if (!dev->ibi)
 		return;
 
-	if (WARN_ON(dev->ibi->enabled))
-		WARN_ON(i3c_dev_disable_ibi_locked(dev));
+	if (dev->ibi->enabled) {
+		dev_err(&master->dev, "Freeing IBI that is still enabled\n");
+		if (i3c_dev_disable_ibi_locked(dev))
+			dev_err(&master->dev, "Failed to disable IBI before freeing\n");
+	}
 
 	master->ops->free_ibi(dev);
 
-- 
2.51.0


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  parent reply	other threads:[~2026-01-08  8:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  8:05 [PATCH V2 00/20] i3c: mipi-i3c-hci-pci: Add Runtime PM support Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 01/20] i3c: mipi-i3c-hci: Reset RING_OPERATION1 fields during init Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 02/20] i3c: mipi-i3c-hci: Ensure proper bus clean-up Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 03/20] i3c: master: Update hot-join flag only on success Adrian Hunter
2026-01-08 14:52   ` Frank Li
2026-01-08  8:05 ` Adrian Hunter [this message]
2026-01-08  8:05 ` [PATCH V2 05/20] i3c: mipi-i3c-hci: Switch DAT bitmap allocation to devm_bitmap_zalloc() Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 06/20] i3c: mipi-i3c-hci: Switch PIO data allocation to devm_kzalloc() Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 07/20] i3c: mipi-i3c-hci: Manage DMA deallocation via devres action Adrian Hunter
2026-01-08 14:56   ` Frank Li
2026-01-08  8:05 ` [PATCH V2 08/20] i3c: mipi-i3c-hci: Cache DAT in memory for Runtime PM restore Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 09/20] i3c: mipi-i3c-hci: Introduce helper to restore DAT Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 10/20] i3c: mipi-i3c-hci: Extract ring initialization from hci_dma_init() Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 11/20] i3c: mipi-i3c-hci: Add DMA suspend and resume support Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 12/20] i3c: mipi-i3c-hci: Refactor PIO register initialization Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 13/20] i3c: mipi-i3c-hci: Add PIO suspend and resume support Adrian Hunter
2026-01-08  8:05 ` [PATCH V2 14/20] i3c: mipi-i3c-hci: Factor out software reset into helper Adrian Hunter
2026-01-08 14:57   ` Frank Li
2026-01-08  8:05 ` [PATCH V2 15/20] i3c: mipi-i3c-hci: Factor out IO mode setting " Adrian Hunter
2026-01-08 15:03   ` Frank Li
2026-01-08  8:05 ` [PATCH V2 16/20] i3c: mipi-i3c-hci: Factor out core initialization " Adrian Hunter
2026-01-08 15:25   ` Frank Li
2026-01-08  8:05 ` [PATCH V2 17/20] i3c: mipi-i3c-hci: Factor out master dynamic address setting " Adrian Hunter
2026-01-08 15:28   ` Frank Li
2026-01-08  8:05 ` [PATCH V2 18/20] i3c: master: Introduce optional Runtime PM support Adrian Hunter
2026-01-08 15:09   ` Frank Li
2026-01-09 11:42     ` Adrian Hunter
2026-01-12 16:04       ` Frank Li
2026-01-08  8:05 ` [PATCH V2 19/20] i3c: mipi-i3c-hci: Add " Adrian Hunter
2026-01-08 15:15   ` Frank Li
2026-01-08  8:05 ` [PATCH V2 20/20] i3c: mipi-i3c-hci-pci: Add " Adrian Hunter
2026-01-08 15:17   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108080558.21767-5-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=aniketmaurya@google.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox