From: Conor Dooley <conor@kernel.org>
To: Manikandan Muralidharan <manikandan.m@microchip.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@nxp.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
linux@armlinux.org.uk, mturquette@baylibre.com, sboyd@kernel.org,
ardb@kernel.org, ebiggers@google.com, martin.petersen@oracle.com,
tytso@mit.edu, cristian.birsan@microchip.com,
adrian.hunter@intel.com, jarkko.nikula@linux.intel.com,
kees@kernel.org, npitre@baylibre.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: i3c: mipi-i3c-hci: add Microchip SAMA7D65 compatible
Date: Thu, 12 Mar 2026 17:50:26 +0000 [thread overview]
Message-ID: <20260312-ardently-untoasted-4f4b79be27c4@spud> (raw)
In-Reply-To: <20260312042056.309237-2-manikandan.m@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 2033 bytes --]
On Thu, Mar 12, 2026 at 09:50:52AM +0530, Manikandan Muralidharan wrote:
> Add the microchip,sama7d65-i3c-hci compatible string to the MIPI I3C
> HCI binding. The Microchip SAMA7D65 I3C controller is based on the
> MIPI HCI specification but requires two clocks, so add a conditional
> constraint when this compatible is present.
>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
> .../devicetree/bindings/i3c/mipi-i3c-hci.yaml | 22 +++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml
> index 39bb1a1784c9..db659388a27d 100644
> --- a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml
> +++ b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml
> @@ -9,9 +9,6 @@ title: MIPI I3C HCI
> maintainers:
> - Nicolas Pitre <npitre@baylibre.com>
>
> -allOf:
> - - $ref: /schemas/i3c/i3c.yaml#
> -
> description: |
> MIPI I3C Host Controller Interface
>
> @@ -28,7 +25,9 @@ description: |
>
> properties:
> compatible:
> - const: mipi-i3c-hci
> + enum:
> + - mipi-i3c-hci
> + - microchip,sama7d65-i3c-hci
> reg:
> maxItems: 1
> interrupts:
> @@ -39,6 +38,21 @@ required:
> - reg
> - interrupts
>
> +allOf:
> + - $ref: /schemas/i3c/i3c.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,sama7d65-i3c-hci
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + required:
> + - clocks
Properties should be defined at the top level, and only restricted in
conditional schemas. Please add them at the top level, and provide some
information as to what each clock is via a description.
pw-bot: changes-requested
Thanks,
Conor.
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.25.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 111 bytes --]
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-04-30 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 4:20 [PATCH v3 0/5] Add microchip sama7d65 SoC I3C support Manikandan Muralidharan
2026-03-12 4:20 ` [PATCH v3 1/5] dt-bindings: i3c: mipi-i3c-hci: add Microchip SAMA7D65 compatible Manikandan Muralidharan
2026-03-12 17:50 ` Conor Dooley [this message]
2026-03-12 4:20 ` [PATCH v3 2/5] clk: at91: sama7d65: add peripheral clock for I3C Manikandan Muralidharan
2026-03-12 4:20 ` [PATCH v3 3/5] i3c: mipi-i3c-hci: add microchip sama7d65 SoC compatible with the appropriate quirk Manikandan Muralidharan
2026-03-12 9:29 ` Adrian Hunter
2026-03-12 17:52 ` Conor Dooley
2026-03-16 6:36 ` Manikandan.M
2026-03-12 4:20 ` [PATCH v3 4/5] ARM: dts: microchip: add I3C controller Manikandan Muralidharan
2026-03-12 4:20 ` [PATCH v3 5/5] ARM: configs: at91: sama7: add sama7d65 i3c-hci Manikandan Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312-ardently-untoasted-4f4b79be27c4@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=ardb@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=manikandan.m@microchip.com \
--cc=martin.petersen@oracle.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=npitre@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox