From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7296F94CA1 for ; Tue, 21 Apr 2026 17:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=P9+4j/iVQdWgwFPdkOr2zUR7xHRxYHwdegngEcIqusc=; b=b4x9R1yXBmRwUs QEfm4LiUt8mPauWVlgqQt2jQodVxLVAp8wqxbi2lFnpwhyw5C9P0HUDdoej9EkT8eYE3bOydX9Jnz VVyPtnd5oW5Vqppe7gCf03RQWMgHTlntwOvQ09QiyofJEUSCxKRxD75cIE7dXlN8qixiLHVbaFXHg VvnB2TIBpaJstxmYOU07u6KlHv/xaZpzaNvAiBG9wKnm55uIoDboThwZdCealOJ9ZDZ1ekGz2E89a BQe412t052GlkFTP4zjxUMIxy88KW/XDafTcmM3S/UndNbcRnNho/qBCwtPSgIorbdJreToZtUxJh +4f2oCDJpZnRihkXnC9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFFJH-00000008zTu-1hae; Tue, 21 Apr 2026 17:54:55 +0000 Received: from mgamail.intel.com ([198.175.65.19]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFFJE-00000008zSH-3FvU for linux-i3c@lists.infradead.org; Tue, 21 Apr 2026 17:54:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776794093; x=1808330093; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ARrAXK2364nOQW9biwNrCtnnFf9vFYyrELyodZn1UzU=; b=ncy+H6OX9Nq3q7dRYbI7R0icvnTDFYkFZE4tpz3p2n4RhVlZDp8CHeLe I5n72j0T7czg7ljV010Qnf0vCw3QxH7QTLBRa+HFdySW1Has+Po6/MhQt LCxNuyBDx7/0dLOu3YQQjmI5utN047qbOhoI2T+K2XAjZiaGJRTJMxNDV 1X8YoppDcfaPCy4zIMi33jo2gq5ATBINeQ6Dyjiur7kdX/iYaRGBrX4sn Ko5SIT7G/DQdoiR7mAYqeXShSZILrdSF3YogF80HZRnuN5fghviWi52gk azfFEwTiHsjIOsbPnKTXnyWSo+riOq+hRflqvnTx1qH5rh62BsxHaTg/i Q==; X-CSE-ConnectionGUID: T/hveE9zS2ieNHELx0pJAg== X-CSE-MsgGUID: +t5ODdPLTjm3N8qHRcvDBw== X-IronPort-AV: E=McAfee;i="6800,10657,11763"; a="77651339" X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="77651339" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 10:54:48 -0700 X-CSE-ConnectionGUID: uslBp+E6TWSBngFWD4bv2w== X-CSE-MsgGUID: r8p59fh0QbyaaNeyiF8LYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="227494827" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.242]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 10:54:46 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 00/16] i3c: mipi-i3c-hci: DMA abort, recovery and related improvements Date: Tue, 21 Apr 2026 20:54:19 +0300 Message-ID: <20260421175435.122094-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260421_105452_906667_F9D032F0 X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org Hi This series improves the robustness of the MIPI I3C HCI DMA mode driver, addressing issues observed during error handling and recovery. Patch 1 ensures suspend always invokes io->suspend. Patches 2-4 fix issues in the existing DMA abort path: preserving the RUN bit during abort per the MIPI specification, blocking enqueue during abort/error, and waiting for ring restart completion. Patches 5-8 improve how partially completed transfer lists are handled during dequeue: moving hci_dma_xfer_done() earlier so completed responses are processed before NoOp replacement, completing transfer lists immediately on error rather than deferring, and detecting when an abort races with transfer completion to avoid restarting the wrong transfer list. Patches 9-10 add Intel-specific quirks for DMA ring abort: a PIO queue reset after abort, and an HC_CONTROL ABORT before the ring-level abort. Patch 11 factors out a reset-and-restore helper from the suspend path for reuse. Patch 12 adds a full DMA recovery path for internal controller errors. When the hardware reports a TID mismatch or the ring becomes stuck, the driver now resets and restores the controller, terminating all in-flight transfers with an error status. Patch 13 makes NoOp command handling observable: instead of discarding NoOp responses, the driver now waits for them to complete and triggers recovery if they fail. Patch 14 adjusts transfer timeout accounting to start from when a transfer actually begins execution rather than when it was queued, preventing premature timeouts behind slow predecessors. Patches 15-16 are minor optimizations: consolidating the DMA command and response ring into a single coherent allocation, and increasing the ring size to the maximum 255 entries to avoid ring-space exhaustion. Changes in V2: i3c: mipi-i3c-hci: Fix suspend behavior when bus disable falls back to software reset Always return 0 from suspend callback Amend commit message i3c: mipi-i3c-hci: Preserve RUN bit when aborting DMA ring Improve commit message i3c: mipi-i3c-hci: Prevent DMA enqueue while ring is aborting or in error Improve commit message i3c: mipi-i3c-hci: Wait for DMA ring restart to complete None i3c: mipi-i3c-hci: Move hci_dma_xfer_done() definition Add Frank's Rev'd-by i3c: mipi-i3c-hci: Call hci_dma_xfer_done() from dequeue path Add Frank's Rev'd-by i3c: mipi-i3c-hci: Complete transfer lists immediately on error Rename completing_xfer to final_xfer i3c: mipi-i3c-hci: Avoid restarting DMA ring after aborting wrong transfer Rename completing_xfer to final_xfer i3c: mipi-i3c-hci: Add DMA ring abort/reset quirk for Intel controllers None i3c: mipi-i3c-hci: Add DMA ring abort quirk for Intel controllers None i3c: mipi-i3c-hci: Factor out reset-and-restore helper Drop redundant i3c_hci_sync_irq_inactive(hci) from i3c_hci_reset_and_restore() because it is called by hci->io->suspend() anyway i3c: mipi-i3c-hci: Add DMA-mode recovery for internal controller errors Rename completing_xfer to final_xfer Add hci_dma_xfer_done() before checking for an already complete transfer Improve commit message i3c: mipi-i3c-hci: Wait for NoOp commands to complete Rename completing_xfer to final_xfer Add missing reinit_completion() i3c: mipi-i3c-hci: Base timeouts on actual transfer start time Do not flag the next transfer as started when there is an error which halts the controller Instead flag it started at the end of hci_dma_dequeue_xfer() Use hci_start_xfer() in pio.c i3c: mipi-i3c-hci: Consolidate DMA ring allocation Check for failed allocation before assignments to avoid doing arithmetic with NULL pointers i3c: mipi-i3c-hci: Increase DMA transfer ring size to maximum None Adrian Hunter (16): i3c: mipi-i3c-hci: Fix suspend behavior when bus disable falls back to software reset i3c: mipi-i3c-hci: Preserve RUN bit when aborting DMA ring i3c: mipi-i3c-hci: Prevent DMA enqueue while ring is aborting or in error i3c: mipi-i3c-hci: Wait for DMA ring restart to complete i3c: mipi-i3c-hci: Move hci_dma_xfer_done() definition i3c: mipi-i3c-hci: Call hci_dma_xfer_done() from dequeue path i3c: mipi-i3c-hci: Complete transfer lists immediately on error i3c: mipi-i3c-hci: Avoid restarting DMA ring after aborting wrong transfer i3c: mipi-i3c-hci: Add DMA ring abort/reset quirk for Intel controllers i3c: mipi-i3c-hci: Add DMA ring abort quirk for Intel controllers i3c: mipi-i3c-hci: Factor out reset-and-restore helper i3c: mipi-i3c-hci: Add DMA-mode recovery for internal controller errors i3c: mipi-i3c-hci: Wait for NoOp commands to complete i3c: mipi-i3c-hci: Base timeouts on actual transfer start time i3c: mipi-i3c-hci: Consolidate DMA ring allocation i3c: mipi-i3c-hci: Increase DMA transfer ring size to maximum drivers/i3c/master/mipi-i3c-hci/cmd.h | 6 + drivers/i3c/master/mipi-i3c-hci/core.c | 82 ++++++-- drivers/i3c/master/mipi-i3c-hci/dma.c | 342 +++++++++++++++++++++++++-------- drivers/i3c/master/mipi-i3c-hci/hci.h | 22 +++ drivers/i3c/master/mipi-i3c-hci/pio.c | 1 + 5 files changed, 363 insertions(+), 90 deletions(-) Regards Adrian -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c