From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16DC4CD6E79 for ; Mon, 8 Jun 2026 20:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z3qvaZu8T+++y6x+U9nE4IvKPEsdUCL5iFtwryGcXck=; b=a3/cJeRXVTseiS XjEsB+Y+MdfEPHo/6qJscpByXT2jnkV5ssAURfdbZLxwq/VuLjOZ7uk0PhJnTfcTCP7ixvWm5d7e3 bmlXDam9dWbjrG1nMNbSbUylLaZ9+8EAQLUV2Ibphyw0MGuFmgepiKNUdymUeq+rkJ7s/92dzx7q4 08DCB+gisMpfspU3JS7g3UxVtc4I/czCRuJm80tLcJ9hOCsNwiJGTMgcINSYzYl6UAsD7gCU7/ZeM FMPcYoR3rDaNH5x19CqWycBL5dQsnlpYsTZ6Y293haoaS5PiazLt8Sh8nC7uobQHf5YXZS7bpMT1z uuVX/CYH0gokZICdeZJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWgcE-00000004MWn-3Oib; Mon, 08 Jun 2026 20:30:34 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWgcD-00000004MWd-14PN for linux-i3c@lists.infradead.org; Mon, 08 Jun 2026 20:30:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A2F5B4013F; Mon, 8 Jun 2026 20:30:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5651A1F00898; Mon, 8 Jun 2026 20:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780950632; bh=OwGfiiVBm/cBK8g4n8mhDKkgOGZ/uo8qolX+5EnEUjc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UWv6a4ISNOTPIqAH7ilDF+66pVpbZuwq7q1+CvrQ8RIppm4AlpbZpSVJ5Ehm6nSrR UQfpgOO8y2a0wYYcc8Zqs7ny0UGl76unJ32fSEusQMX7wBTRIfpWsKW9z86Ky2cdIl Ldfqat92yHATa7fx6gXNyLmauw/YXKJf2ghf7HV6MRpobjGg6kEriMUCBlIHxfFXAt NLQ43zKniK71036qPPYzvZM0Iziy6d+36z4BbcEVXbYczEWuOSuh8tuiwJgEz9uI1g 7X6mqnXyBX4xn62tGALOpVMPrXqW1Pob4tLkYlveXsHKcYiLX0tkjJx+xJErmKTR8g XhTW5nkiLvj2w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 11/17] i3c: renesas: Follow a unified pattern for transfer and command initialization To: "Claudiu Beznea" Cc: linux-i3c@lists.infradead.org, wsa+renesas@sang-engineering.com, Frank.Li@kernel.org In-Reply-To: <20260608201543.804902-12-claudiu.beznea@kernel.org> References: <20260608201543.804902-12-claudiu.beznea@kernel.org> Date: Mon, 08 Jun 2026 20:30:31 +0000 Message-Id: <20260608203032.5651A1F00898@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtDcml0aWNhbF0gTWlzc2luZyBib3VuZHMgY2hlY2tzIGFuZCBpbnRlZ2VyIHVuZGVyZmxvdyBp biBSWCBpbnRlcnJ1cHQgaGFuZGxlcnMgbGVhZCB0byBtYXNzaXZlIG91dC1vZi1ib3VuZHMgaGVh cCB3cml0ZXMuCi0gW0hpZ2hdIEkzQyBhbmQgSTJDIHRyYW5zZmVyIGxvb3BzIGlnbm9yZSBoYXJk d2FyZSBlcnJvcnMgYW5kIHRpbWVvdXRzLCBzaWxlbnRseSByZXR1cm5pbmcgc3VjY2VzcyBhbmQg cmlza2luZyBzdGF0ZSBjb3JydXB0aW9uLgotLQoKY29tbWl0IDFiZTg1Mjg5NDE5NDAzMzNlOTA3 MDU3NzBmMGE5NzdmOTVkOWIzZDUKQXV0aG9yOiBDbGF1ZGl1IEJlem5lYSA8Y2xhdWRpdS5iZXpu ZWEudWpAYnAucmVuZXNhcy5jb20+CgppM2M6IHJlbmVzYXM6IEZvbGxvdyBhIHVuaWZpZWQgcGF0 dGVybiBmb3IgdHJhbnNmZXIgYW5kIGNvbW1hbmQgaW5pdGlhbGl6YXRpb24KCkZvbGxvdyBhIHVu aWZpZWQgcGF0dGVybiBmb3IgdHJhbnNmZXIgYW5kIGNvbW1hbmQgaW5pdGlhbGl6YXRpb24gYWNy b3NzCnRoZSBkcml2ZXIuIFRoaXMga2VlcHMgdGhlIGNvZGUgY2xlYW5lciBhbmQgZWFzaWVyIHRv IGZvbGxvdy4gQWxzbywgaW4Kc29tZSBjYXNlcyB0aGUgSTNDIGRldmljZSB3YXMgZW5hYmxlZCBi ZWZvcmUgdGhlIHRyYW5zZmVyIGRhdGEgc3RydWN0dXJlCndhcyBldmVuIGFsbG9jYXRlZC4KCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rlci9yZW5lc2FzLWkzYy5jIGIvZHJpdmVycy9p M2MvbWFzdGVyL3JlbmVzYXMtaTNjLmMKPiAtLS0gYS9kcml2ZXJzL2kzYy9tYXN0ZXIvcmVuZXNh cy1pM2MuYwo+ICsrKyBiL2RyaXZlcnMvaTNjL21hc3Rlci9yZW5lc2FzLWkzYy5jClsgLi4uIF0K PiBAQCAtOTM5LDE1ICs5MzksMTUgQEAgc3RhdGljIGludCByZW5lc2FzX2kzY19pM2NfeGZlcnMo c3RydWN0IGkzY19kZXZfZGVzYyAqZGV2LCBzdHJ1Y3QgaTNjX3hmZXIgKmkzY18KPiAgCXN0cnVj dCByZW5lc2FzX2kzY19pMmNfZGV2X2RhdGEgKmRhdGEgPSBpM2NfZGV2X2dldF9tYXN0ZXJfZGF0 YShkZXYpOwo+ICAJaW50IGk7Cj4gIAo+IC0JLyogRW5hYmxlIEkzQyBidXMuICovCj4gLQlyZW5l c2FzX2kzY19idXNfZW5hYmxlKG0sIHRydWUpOwo+IC0KPiAgCXN0cnVjdCByZW5lc2FzX2kzY194 ZmVyICp4ZmVyIF9fZnJlZShrZnJlZSkgPSByZW5lc2FzX2kzY19hbGxvY194ZmVyKGkzYywgMSk7 Cj4gIAlpZiAoIXhmZXIpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICAJaW5pdF9jb21wbGV0 aW9uKCZ4ZmVyLT5jb21wKTsKPiAgCj4gKwkvKiBFbmFibGUgSTNDIGJ1cy4gKi8KPiArCXJlbmVz YXNfaTNjX2J1c19lbmFibGUobSwgdHJ1ZSk7Cj4gKwo+ICAJZm9yIChpID0gMDsgaSA8IGkzY19u eGZlcnM7IGkrKykgewo+ICAJCXN0cnVjdCByZW5lc2FzX2kzY19jbWQgKmNtZCA9IHhmZXItPmNt ZHM7CgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXNuJ3QgYSBidWcgaW50cm9kdWNlZCBieSB0aGlz IHBhdGNoLCBidXQgd2hpbGUgcmV2aWV3aW5nIHRoZSB0cmFuc2Zlcgppbml0aWFsaXphdGlvbiBo ZXJlLCBJIG5vdGljZWQgYW4gaXNzdWUgaW4gdGhlIGxvb3AgYmVsb3cuCgpEb2VzIHRoZSBsb29w IGlnbm9yZSBoYXJkd2FyZSBlcnJvcnMgYW5kIHRpbWVvdXRzPyBJdCBsb29rcyBsaWtlIHRoZSBo YXJkd2FyZQplcnJvciBzdGF0dXMgaW4geGZlci0+cmV0IGlzIG5vdCBjaGVja2VkLCBhbmQgdGhl IGZ1bmN0aW9uIHVuY29uZGl0aW9uYWxseQpyZXR1cm5zIDA6CgogICAgdGltZV9sZWZ0ID0gcmVu ZXNhc19pM2Nfd2FpdF94ZmVyKGkzYywgeGZlcik7CiAgICBpZiAoIXRpbWVfbGVmdCkKICAgICAg ICBhYm9ydF94ZmVyID0gdHJ1ZTsKfQoKaWYgKGFib3J0X3hmZXIpCiAgICByZW5lc2FzX2kzY19h Ym9ydF94ZmVyKGkzYyk7CgpyZXR1cm4gMDsKCkFsc28sIG9uIHRpbWVvdXQsIGl0IHNldHMgYWJv cnRfeGZlciA9IHRydWUgYnV0IGRvZXNuJ3QgYnJlYWsgb3V0IG9mIHRoZQpsb29wLCB3aGljaCBt ZWFucyBpdCByZXVzZXMgdGhlIGFjdGl2ZSB4ZmVyIHN0cnVjdCBmb3IgdGhlIG5leHQgdHJhbnNm ZXIKd2hpbGUgdGhlIGhhcmR3YXJlIGhhc24ndCBiZWVuIGFib3J0ZWQgeWV0LiBDYW4gdGhpcyBs ZWFkIHRvIHN0YXRlCmNvcnJ1cHRpb24gb3IgaW5mb3JtYXRpb24gbGVha3M/CgpbIC4uLiBdCj4g QEAgLTEwNzMsMTIgKzEwNzMsMTIgQEAgc3RhdGljIGludCByZW5lc2FzX2kzY19pMmNfeGZlcnMo c3RydWN0IGkyY19kZXZfZGVzYyAqZGV2LAo+ICAJaWYgKCF4ZmVyKQo+ICAJCXJldHVybiAtRU5P TUVNOwo+ICAKPiAtCXJlbmVzYXNfaTNjX2J1c19lbmFibGUobSwgZmFsc2UpOwo+IC0KPiAgCWlu aXRfY29tcGxldGlvbigmeGZlci0+Y29tcCk7Cj4gIAl4ZmVyLT5pc19pMmNfeGZlciA9IHRydWU7 Cj4gIAljbWQgPSB4ZmVyLT5jbWRzOwo+ICAKPiArCXJlbmVzYXNfaTNjX2J1c19lbmFibGUobSwg ZmFsc2UpOwo+ICsKPiAgCWlmICghKHJlbmVzYXNfcmVhZGwoaTNjLT5yZWdzLCBCQ1NUKSAmIEJD U1RfQkZSRUYpKSB7Cj4gIAkJY21kLT5lcnIgPSAtRUJVU1k7Cj4gIAkJcmV0dXJuIGNtZC0+ZXJy OwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGFsc28gYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1 dCBJIHNlZSBhIHNpbWlsYXIgcGF0dGVybiBpbgpyZW5lc2FzX2kzY19pMmNfeGZlcnMoKSB3aGVy ZSBpdCBtaWdodCBmYWlsIHRvIGJyZWFrIG91dCBvZiB0aGUgbG9vcAp3aGVuIGEgdGltZW91dCBv Y2N1cnM6CgogICAgdGltZV9sZWZ0ID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCZ4ZmVy LT5jb21wLCBtLT5pMmMudGltZW91dCk7CiAgICBpZiAoIXRpbWVfbGVmdCkKICAgICAgICBhYm9y dF94ZmVyID0gdHJ1ZTsKCiAgICBpZiAoY21kLT5lcnIpCiAgICAgICAgYnJlYWs7CgpTaW5jZSBj bWQtPmVyciByZW1haW5zIDAgb24gdGltZW91dCwgdGhlIGxvb3AgY29udGludWVzIHRvIHRoZSBu ZXh0IG1lc3NhZ2UKYW5kIGV2ZW50dWFsbHkgcmV0dXJucyAwIGluc3RlYWQgb2YgcHJvcGFnYXRp bmcgdGhlIHRpbWVvdXQuIFNob3VsZCB0aGUgbG9vcApicmVhayB3aGVuIGFib3J0X3hmZXIgaXMg c2V0IHRvIHRydWU/CgpbIC4uLiBdCgpbU2V2ZXJpdHk6IENyaXRpY2FsXQpUaGlzIGlzIGEgcHJl LWV4aXN0aW5nIGlzc3VlIG5vdCBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCB3aGlsZQpy ZXZpZXdpbmcgdGhlIGRyaXZlciBJIG5vdGljZWQgcG90ZW50aWFsIG91dC1vZi1ib3VuZHMgd3Jp dGVzIGluIHRoZQpSWCBpbnRlcnJ1cHQgaGFuZGxlcnMuCgpJbiByZW5lc2FzX2kzY19yeF9pc3Io KSwgaXMgdGhlcmUgYSBtaXNzaW5nIGJvdW5kcyBjaGVjayBhZ2FpbnN0IGNtZC0+bGVuPwpUaGUg ZGF0YSBzZWVtcyB0byBiZSByZWFkIGRpcmVjdGx5IGludG8gY21kLT5yeF9idWYgYmFzZWQgb24g dGhlIEZJRk8gZmlsbApsZXZlbCB3aXRob3V0IHZhbGlkYXRpbmcgaXQgYWdhaW5zdCB0aGUgYWxs b2NhdGVkIGxlbmd0aDoKCiAgICB9IGVsc2UgewogICAgICAgIHJlYWRfYnl0ZXMgPSBOREJTVExW MF9SREJMVihyZW5lc2FzX3JlYWRsKGkzYy0+cmVncywgTkRCU1RMVjApKSAqIHNpemVvZih1MzIp OwogICAgICAgIGkzY19yZWFkbF9maWZvKGkzYy0+cmVncyArIE5URFRCUDAsIGNtZC0+cnhfYnVm LCByZWFkX2J5dGVzKTsKICAgICAgICBjbWQtPnJ4X2NvdW50ID0gcmVhZF9ieXRlczsKICAgIH0K Ckl0IGxvb2tzIGxpa2UgdGhpcyBhbHNvIG92ZXJ3cml0ZXMgdGhlIHN0YXJ0IG9mIGNtZC0+cnhf YnVmIGFuZCBvdmVyd3JpdGVzCmNtZC0+cnhfY291bnQgaW5zdGVhZCBvZiBhcHBlbmRpbmcgb3Ig aW5jcmVtZW50aW5nLgoKQWRkaXRpb25hbGx5LCBpbiByZW5lc2FzX2kzY19yZXNwX2lzcigpLCBk b2VzIHRoZSBzdWJ0cmFjdGlvbiByaXNrIGludGVnZXIKdW5kZXJmbG93PwoKICAgIGlmIChOREJT VExWMF9SREJMVihyZW5lc2FzX3JlYWRsKGkzYy0+cmVncywgTkRCU1RMVjApKSAmJiAhY21kLT5l cnIpCiAgICAgICAgYnl0ZXNfcmVtYWluaW5nID0gZGF0YV9sZW4gLSBjbWQtPnJ4X2NvdW50OwoK ICAgIGkzY19yZWFkbF9maWZvKGkzYy0+cmVncyArIE5URFRCUDAsIGNtZC0+cnhfYnVmLCBieXRl c19yZW1haW5pbmcpOwoKSWYgZGF0YV9sZW4gZnJvbSB0aGUgcmVzcG9uc2UgZGVzY3JpcHRvciBp cyBzbWFsbGVyIHRoYW4gY21kLT5yeF9jb3VudCwgdGhpcwpzdWJ0cmFjdGlvbiBjb3VsZCB1bmRl cmZsb3cuIFdoZW4gcGFzc2VkIHRvIGkzY19yZWFkbF9maWZvKCksIHRoZSB2YWx1ZQpjb3VsZCBi ZWNvbWUgYSBuZWdhdGl2ZSBpbnRlZ2VyLCB3aGljaCBpcyBpbXBsaWNpdGx5IGNhc3QgdG8gYSBt YXNzaXZlCnBvc2l0aXZlIHNpemUgaW4gcmVhZHNsKCkuIENvdWxkIHRoaXMgY2F1c2UgYSByZW1v dGUgaGVhcCBvdmVyZmxvdz8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hp a28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA2MDgyMDE1NDMuODA0OTAyLTEtY2xhdWRpdS5iZXpuZWFA a2VybmVsLm9yZz9wYXJ0PTExCgotLSAKbGludXgtaTNjIG1haWxpbmcgbGlzdApsaW51eC1pM2NA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWkzYwo=