From: sashiko-bot@kernel.org
To: "Swark Yang" <syang@axiado.com>
Cc: linux-i3c@lists.infradead.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
robh@kernel.org, Frank.Li@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant
Date: Fri, 17 Jul 2026 04:00:55 +0000 [thread overview]
Message-ID: <20260717040056.6BA971F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716-upstream-axiado-ax3005-upstream-v3-2-c429095143ec@axiado.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The schema enforces a 3-item compatible string chain that unintentionally forces AX3005 devices to inherit an AX3000-specific driver quirk, contradicting the commit message.
--
--- Patch [2]: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant ---
commit 53c67e7dc4609ee9e61f57a1d43c9c6ca04d123b
Author: Swark Yang <syang@axiado.com>
dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant
Add binding for the Axiado AX3005 GPIO controller. The commit message states
there are no known changes and it should fall back directly to the
cdns,gpio-r1p02 compatible string.
> diff --git a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> --- a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> @@ -14,8 +14,11 @@ properties:
> oneOf:
> - const: cdns,gpio-r1p02
> - items:
> - - enum:
> - - axiado,ax3000-gpio
> + - const: axiado,ax3000-gpio
> + - const: cdns,gpio-r1p02
> + - items:
> + - const: axiado,ax3005-gpio
> + - const: axiado,ax3000-gpio
> - const: cdns,gpio-r1p02
[Severity: High]
Does forcing axiado,ax3000-gpio into the 3-item compatible string chain
unintentionally cause AX3005 devices to inherit AX3000-specific driver
quirks?
By requiring the axiado,ax3000-gpio compatible string in the fallback chain,
any AX3005 device tree must include it to pass schema validation. The
underlying driver will then match this intermediate string via
device_get_match_data() and apply ax3000_gpio_quirks, such as skipping
initialization of CDNS_GPIO_DIRECTION_MODE and CDNS_GPIO_OUTPUT_EN.
The commit message states the intent is to fall back to the cdns,gpio-r1p02
compatible. Should axiado,ax3005-gpio instead be added to an enum alongside
axiado,ax3000-gpio in a 2-item fallback chain, avoiding the intermediate
AX3000 string entirely?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-upstream-axiado-ax3005-upstream-v3-0-c429095143ec@axiado.com?part=2
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-07-17 4:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 3:51 [PATCH v3 0/8] arm64: Add Axiado AX3005 SoC and EVK support Swark Yang
2026-07-17 3:51 ` [PATCH v3 1/8] dt-bindings: arm: axiado: add AX3005 EVK Swark Yang
2026-07-17 3:51 ` [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant Swark Yang
2026-07-17 4:00 ` sashiko-bot [this message]
2026-07-17 7:57 ` Swark Yang
2026-07-17 8:30 ` Krzysztof Kozlowski
2026-07-17 8:33 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 3/8] dt-bindings: i2c: cdns: add Axiado AX3005 I2C variant Swark Yang
2026-07-17 8:32 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 4/8] dt-bindings: i3c: cdns: add Axiado AX3005 I3C variant Swark Yang
2026-07-17 8:32 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 5/8] dt-bindings: serial: cdns: add Axiado AX3005 UART variant Swark Yang
2026-07-17 8:32 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 6/8] dt-bindings: spi: dw-apb-ssi: add Axiado AX3005 SPI variant Swark Yang
2026-07-17 8:34 ` Krzysztof Kozlowski
2026-07-17 8:35 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 7/8] dt-bindings: usb: generic-xhci: add Axiado AX3005 xHCI variant Swark Yang
2026-07-17 8:37 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 8/8] arm64: dts: axiado: Add initial support for AX3005 SoC and eval board Swark Yang
2026-07-17 8:58 ` (subset) [PATCH v3 0/8] arm64: Add Axiado AX3005 SoC and EVK support Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717040056.6BA971F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=syang@axiado.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox