From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Shubham Patil <shubhamsanjay.patil@amd.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@nxp.com,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, radhey.shyam.pandey@amd.com,
michal.simek@amd.com
Subject: Re: [PATCH] dt-bindings: i3c: dw: Document missing optional core reset
Date: Wed, 22 Jul 2026 14:23:15 -0500 [thread overview]
Message-ID: <20260722192315.GA1314342-robh@kernel.org> (raw)
In-Reply-To: <f0278842-ceba-4d90-9dc0-4a15a7e7b342@kernel.org>
On Fri, Jul 17, 2026 at 01:33:15PM +0200, Krzysztof Kozlowski wrote:
> On 17/07/2026 12:58, Shubham Patil wrote:
> > The DesignWare I3C master IP supports a core reset input, but the
> > binding is missing the corresponding reset description.
> >
> > Document the reset property and name in the binding. Keep the reset
> > optional because the reset line is integration-specific..
> >
> > Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> > ---
> > Note:
> > The DesignWare I3C driver support was added by
> > 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
> >
> > The original Synopsys DesignWare I3C binding was added by
> > 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
> > but it did not document the optional core reset.
> > ---
> > .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> > index e803457d3f55..822faf8d221b 100644
> > --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> > +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> > @@ -38,6 +38,12 @@ properties:
> > interrupts:
> > maxItems: 1
> >
> > + resets:
> > + maxItems: 1
> > +
> > + reset-names:
> > + const: core_rst
>
> Drop the names, pretty redundant, and fix the driver. Sneaking ABI is a
> poor excuse, IMO, to keep discouraged names.
While fixing the driver, the clock names sashiko pointed out can be
fixed too.
Rob
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2026-07-22 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 10:58 [PATCH] dt-bindings: i3c: dw: Document missing optional core reset Shubham Patil
2026-07-17 11:10 ` sashiko-bot
2026-07-17 11:33 ` Krzysztof Kozlowski
2026-07-22 19:23 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722192315.GA1314342-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=shubhamsanjay.patil@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox