From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E85FAC55184 for ; Tue, 4 Aug 2026 13:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EZVVsBSA3XqCFkzCeIys1DizjQDtOZJZfcTeNiDclds=; b=05Oa1rlXF8Z8IY jqBgC4mGynb6/3hH8zXAe7jefVjUmF5b2c8dW/VnNFq9LEVm2vY/KoXZpUDfVipY4e8y3sIiglZox IqjDqyNZ0u6Iu7vEmSxMq442/2sqSxHCLHhdeCOayOUJ/eFbMXCWmLGeQn0KVLHRREjzr14Q8kLx5 en7ClBpL/6tiG5mSQGj5w3TGHkHUQGmprivdzEArN4faNVTaLS+MSoR5JQi4YOxi1EqkcfmVcizU2 J6TCeqsm6CgkWQ2iaQxn5h8Y2MHBCK4zveGiUgAjQgCSpo7JEoM59pBO6eiguJPzYaS1sO9hEb83R WgQDeo+QtbOZdfroZ9eA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrFLs-00000001wWy-2h5P; Tue, 04 Aug 2026 13:38:40 +0000 Received: from mgamail.intel.com ([198.175.65.17]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrFLo-00000001wP5-3gU1 for linux-i3c@lists.infradead.org; Tue, 04 Aug 2026 13:38:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785850717; x=1817386717; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Z/5ENodMgYfqvmrtqI5X0lDZjP+qbTBkC8CDKItDX9o=; b=GzYLg/rnFPjQu+68SWehDeE+kipxfJ7jwAxHeTHwCBD/73ISKywi/TmI i9mUfZUrMfgzUrnK4Jw5WYmV7FoXBlyJj9fMiGHKGF3NIizp5u8+uqtqO IYlM1XLsr5SMIwQbcgN5zNLi2gkzqoYFhU7r7YwShNuivr68/OSxQAxEw hZjuM5H1Py6L34M9wElogADpaQ9wPgF7gBJeY+hAuTzGaMEGvHtugSXl5 aC3dgcLh+z9ssTm1pri5CsZdvkP/VQVF7pHO0r/2ZmNDRHNEGcJPxCeMr 2oCcDEf3DgiO5jSJlqn5O0NP6rMdGHLwbrOjvkYTCpLcjCfOrl7czI92G w==; X-CSE-ConnectionGUID: ETOOgGexTVuv0vLANAORkw== X-CSE-MsgGUID: SHIeZapiS0iGwoIpoSfdxg== X-IronPort-AV: E=McAfee;i="6800,10657,11864"; a="86410125" X-IronPort-AV: E=Sophos;i="6.25,204,1779174000"; d="scan'208";a="86410125" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2026 06:38:37 -0700 X-CSE-ConnectionGUID: T16+ul3uRemZyyA5RJdc5Q== X-CSE-MsgGUID: Lh9kcuOvRnm1kWEAks3TSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,204,1779174000"; d="scan'208";a="263501021" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.245.132]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2026 06:38:34 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, akhilrajeev@nvidia.com, rafael@kernel.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH V3 06/14] i3c: master: Fix potential UAF in i3c_device_uevent() Date: Tue, 4 Aug 2026 16:38:02 +0300 Message-ID: <20260804133810.184905-7-adrian.hunter@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260804133810.184905-1-adrian.hunter@intel.com> References: <20260804133810.184905-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260804_063836_958720_7E543E48 X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org i3c_device_uevent() dereferences i3cdev->desc without holding the bus normal-use lock. Since the descriptor pointer can be replaced concurrently, including when a uevent is generated from sysfs, this can result in dereferencing a stale descriptor and lead to a use-after-free. Use i3c_device_get_info() instead, which protects access to the descriptor with the normal-use lock. Commit 6cf7b65f7029 ("i3c: Use i3cdev->desc->info instead of calling i3c_device_get_info() to avoid deadlock") replaced the accessor with a direct descriptor dereference because i3c_device_get_info() would recursively acquire bus->lock during device registration. This change depends on "i3c: master: Fix recursive locking during device registration", which moves device registration out from under bus->lock and removes the possibility of that deadlock. Without that change, restoring the i3c_device_get_info() call would reintroduce the deadlock. Fixes: 6cf7b65f7029 ("i3c: Use i3cdev->desc->info instead of calling i3c_device_get_info() to avoid deadlock") Cc: stable@vger.kernel.org # requires "i3c: master: Fix recursive locking during device registration" Signed-off-by: Adrian Hunter --- Changes in V3: New patch drivers/i3c/master.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 4839c1c186eb..947ab3c681d5 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -316,8 +316,7 @@ static int i3c_device_uevent(const struct device *dev, struct kobj_uevent_env *e struct i3c_device_info devinfo; u16 manuf, part, ext; - if (i3cdev->desc) - devinfo = i3cdev->desc->info; + i3c_device_get_info(i3cdev, &devinfo); manuf = I3C_PID_MANUF_ID(devinfo.pid); part = I3C_PID_PART_ID(devinfo.pid); ext = I3C_PID_EXTRA_INFO(devinfo.pid); -- 2.53.0 -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c