Re: [PATCH v4 1/2] dt-bindings: i3c: Add adi-i3c-master

Frank Li
2025-06-26T17:39:00Z

On Thu, Jun 26, 2025 at 12:07:36PM +0200, Jorge Marques wrote:
> Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable IP
> core that implements the MIPI I3C Basic controller specification.
>
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> .../bindings/i3c/adi,i3c-master-1.00.a.yaml | 66 ++++++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 71 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i3c/adi,i3c-master-1.00.a.yaml b/Documentation/devicetree/bindings/i3c/adi,i3c-master-1.00.a.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..9bad24187800cb47090f440b70c519b3f710adf2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/adi,i3c-master-1.00.a.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/adi,i3c-master-1.00.a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices I3C Controller
> +
> +description: |
> + FPGA-based I3C controller designed to interface with I3C and I2C peripherals,
> + implementing a subset of the I3C-basic specification.
> +
> + https://analogdevicesinc.github.io/hdl/library/i3c_controller
> +
> +maintainers:
> + - Jorge Marques <jorge.marques@analog.com>
> +
> +properties:
> + compatible:
> + const: adi,i3c-master-1.00.a
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + items:
> + - description: The AXI interconnect clock, drives the register map.
> + - description: The I3C controller clock. AXI clock drives all logic if not provided.
> +
> + clock-names:
> + minItems: 1
> + items:
> + - const: axi
> + - const: i3c
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> +
> +allOf:
> + - $ref: i3c.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i3c@44a00000 {
> + compatible = "adi,i3c-master-1.00.a";
> + reg = <0x44a00000 0x1000>;
> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clkc 15>, <&clkc 15>;
> + clock-names = "axi", "i3c";
> + #address-cells = <3>;
> + #size-cells = <0>;
> +
> + /* I3C and I2C devices */
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 96b82704950184bd71623ff41fc4df31e4c7fe87..6f56e17dcecf902c6812827c1ec3e067c65e9894 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11243,6 +11243,11 @@ S: Maintained
> F: Documentation/devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml
> F: drivers/i3c/master/ast2600-i3c-master.c
>
> +I3C DRIVER FOR ANALOG DEVICES I3C CONTROLLER IP
> +M: Jorge Marques <jorge.marques@analog.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml
> +
> I3C DRIVER FOR CADENCE I3C MASTER IP
> M: Przemysław Gaj <pgaj@cadence.com>
> S: Maintained
>
> --
> 2.49.0
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c