Re: [PATCH v4 1/2] dt-bindings: i3c: Add adi-i3c-master

Jorge Marques
2025-06-27T17:19:10Z

On Fri, Jun 27, 2025 at 04:49:19PM +0200, Krzysztof Kozlowski wrote:
> On 27/06/2025 16:38, Jorge Marques wrote:
> > On Fri, Jun 27, 2025 at 08:56:55AM +0200, Krzysztof Kozlowski wrote:
> >> On Thu, Jun 26, 2025 at 12:07:36PM +0200, Jorge Marques wrote:
> >>> Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable IP
> >>> core that implements the MIPI I3C Basic controller specification.
> >>
> >> How did you resolve my last comment? I don't see any explanation -
> >> neither here nor in the binding description. Binding description is
> >> actually better place, I think now.
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >
> > Hi Krzysztof,
> >
> > I forgot to condense out discussion on v4.
> > What about this binding description:
> >
> > description: |
> > FPGA-based I3C controller designed to interface with I3C and I2C
> > peripherals, implementing a subset of the I3C-basic specification.
> > The IP core is tested on arm, microblaze, and arm64 architectures.
> > It takes one or two clocks, axi and i3c. If only axi is provided,
> > then there is no clock signal to the i3c input clock pin and axi
>
> This is obvious from the schema, drop.
Ack.

>
> > clock drives the whole IP. The compatible is suffixed by 1.00.a
> > foreseeing future controllers by Analog Devices Inc. and breaking
> > changes.
>
> I don't understand that. How are you breaking any changes? And how
> 1.00.a predicts future? I don't think this reflects previous discussion.
> Why you were asked to go with v1.00.a?
The -1.00.a suffix came from this discussion:

https://lore.kernel.org/linux-i3c/ildi2pup2zkyv4stuknkrjysex3yzsbrrsrwbgcc4xgvdhwrdd@7qh4y6mutgy2/

Other adi bindings use this suffix. I personally wouldn't add any suffix
unless told otherwise, as I expressed on the thread. Should I drop it?
or suffix it with something else?
>
> Best regards,
> Krzysztof

Best regards,
Jorge