Re: [PATCH 5/5] i3c: mipi-i3c-hci: Convert remaining DBG() prints to dev_dbg()

[Jarkko Nikula <jarkko.nikula@linux.intel.com>]

On 9/15/25 11:14 AM, Alexandre Belloni wrote:
> On 15/09/2025 11:06:54+0300, Jarkko Nikula wrote:
>> On 9/12/25 5:31 PM, Frank Li wrote:
>>> On Wed, Aug 27, 2025 at 01:30:09PM +0300, Jarkko Nikula wrote:
>>>> Get rid of local DBG() macro and convert remaining debug prints to
>>>> dev_dbg() which can be controlled without code recompile when kernel is
>>>> built with dynamic debug support.
>>>>
>>>> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>>>> ---
>>>>    drivers/i3c/master/mipi-i3c-hci/cmd_v1.c   |  9 ++-
>>>>    drivers/i3c/master/mipi-i3c-hci/cmd_v2.c   |  7 ++-
>>>>    drivers/i3c/master/mipi-i3c-hci/core.c     | 16 +++---
>>>>    drivers/i3c/master/mipi-i3c-hci/dma.c      | 15 +++--
>>>>    drivers/i3c/master/mipi-i3c-hci/ext_caps.c | 11 ++--
>>>>    drivers/i3c/master/mipi-i3c-hci/hci.h      |  3 -
>>>>    drivers/i3c/master/mipi-i3c-hci/pio.c      | 66 +++++++++++++---------
>>>>    7 files changed, 72 insertions(+), 55 deletions(-)
>>> ...
>>>> -#define DBG(x, ...) pr_devel("%s: " x "\n", __func__, ##__VA_ARGS__)
>>>> -
>>>>    /* 32-bit word aware bit and mask macros */
>>>>    #define W0_MASK(h, l)  GENMASK((h) - 0,  (l) - 0)
>>>>    #define W1_MASK(h, l)  GENMASK((h) - 32, (l) - 32)
>>>> diff --git a/drivers/i3c/master/mipi-i3c-hci/pio.c b/drivers/i3c/master/mipi-i3c-hci/pio.c
>>>> index cde883137bc7..01e7d2833301 100644
>>>> --- a/drivers/i3c/master/mipi-i3c-hci/pio.c
>>>> +++ b/drivers/i3c/master/mipi-i3c-hci/pio.c
>>>> @@ -213,7 +213,7 @@ static void hci_pio_cleanup(struct i3c_hci *hci)
>>>>    	pio_reg_write(INTR_SIGNAL_ENABLE, 0x0);
>>>>
>>>>    	if (pio) {
>>>> -		DBG("status = %#x/%#x",
>>>> +		dev_dbg(&hci->master.dev, "status = %#x/%#x",
>>>>    		    pio_reg_read(INTR_STATUS), pio_reg_read(INTR_SIGNAL_ENABLE));
>>>
>>> fix pio_reg_read() align to (
>>>
>> Ah, this slipped my eyes. I can send a follow up patch giving kudos to you
>> since this patch was now applied or leave it as it.
> 
> I fixed it while applying.
> 
Thanks!

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c