From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Dylan Hung <dylan_hung@aspeedtech.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"joel@jms.id.au" <joel@jms.id.au>,
"u.kleine-koenig@pengutronix.de"
<u.kleine-koenig@pengutronix.de>,
"gustavoars@kernel.org" <gustavoars@kernel.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"zenghuchen@google.com" <zenghuchen@google.com>,
"matt@codeconstruct.com.au" <matt@codeconstruct.com.au>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [PATCH] i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling
Date: Mon, 06 May 2024 14:58:06 +0800 [thread overview]
Message-ID: <52f4e4afef87c336f054ca1c43eec58d2e44a5b1.camel@codeconstruct.com.au> (raw)
In-Reply-To: <TYZPR06MB65678EE7611DDB825E5404C19C1C2@TYZPR06MB6567.apcprd06.prod.outlook.com>
Hi Dylan,
> > The initial state would be to have all SIRs masked.
> >
>
> Yes, indeed. The "global" variable is also true because "reg ==
> 0xffffffff" is true.
> Therefore, the INTR_IBI_THLD_STAT bit will be set in the following
> code.
That's mainly my point - none of this code is ever run unless the
->enable_ibi or ->disable_ibi controller callback is invoked.
So we'll end up with the HJ interrupt only being enabled if some i3c
device driver enables IBIs, which is a bit of a weird side-effect.
It probably makes more sense when the rest of the HJ code is added, but
not so much as a standalone patch.
Cheers,
Jeremy
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2024-05-06 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 5:45 [PATCH] i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling Dylan Hung
2024-02-18 23:32 ` Alexandre Belloni
2024-05-01 6:22 ` Jeremy Kerr
2024-05-02 5:24 ` Dylan Hung
2024-05-06 5:09 ` Jeremy Kerr
2024-05-06 5:48 ` Dylan Hung
2024-05-06 6:58 ` Jeremy Kerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f4e4afef87c336f054ca1c43eec58d2e44a5b1.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=BMC-SW@aspeedtech.com \
--cc=alexandre.belloni@bootlin.com \
--cc=dylan_hung@aspeedtech.com \
--cc=gustavoars@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zenghuchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox