From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org
Cc: linux-aspeed@lists.ozlabs.org, linux-i3c@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [RFC PATCH] dt-bindings: Add AST2600 i3c controller binding
Date: Mon, 13 Feb 2023 17:21:28 +0800 [thread overview]
Message-ID: <80fa21969d9e0e7a123bd525199dbb40e79d47e3.camel@codeconstruct.com.au> (raw)
In-Reply-To: <929a30fc-35f3-ab21-3a16-936ed69d5505@linaro.org>
Hi Krzysztof,
> You should clearly communicate that driver is coming...
OK.
> Anyway binding comes with the driver, otherwise how can we check that
> you actually implemented it?
I'll include this with the driver once we're past the RFC reviews.
> Please send patches, not RFC. RFC means you are uncertain this is even
> correct and you ask for generic discussion.
Yes, that's essentially what I'm looking for with this change -
particularly with the pullup config, which (as you say) could arguably
be a pinctrl config instead.
If we do decide to do this with pinctrl config, we'll need a separate
driver (and minimal binding) for the global register set to act as the pin
controller. That fundamentally changes the structure here - hence RFC.
> generic discussion comment - implement how other recent i3c bindings
> are implemented. This is basic device, there is nothing special here.
I'd say the global register set makes the binding layout a bit quirky,
as you've identified already.
> Since you did not respond to rest of comments, I assume you are going
> to implement them fully - including dropping the questioned
> properties.
Yep! Some of those will then be unneeded in this binding after going to a
pinctrl approach, and I'll make the fixes as you suggested.
Cheers,
Jeremy
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-02-13 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 7:41 [RFC PATCH] dt-bindings: Add AST2600 i3c controller binding Jeremy Kerr
2023-02-13 8:42 ` Krzysztof Kozlowski
2023-02-13 8:55 ` Jeremy Kerr
2023-02-13 9:05 ` Krzysztof Kozlowski
2023-02-13 9:21 ` Jeremy Kerr [this message]
2023-02-13 9:35 ` Krzysztof Kozlowski
2023-02-13 14:04 ` Jeremy Kerr
2023-02-13 15:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fa21969d9e0e7a123bd525199dbb40e79d47e3.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i3c@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox