Re: [PATCH] [v3, apply after -rc1] i3c: simplify combined i3c/i2c dependencies

From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"Guenter Roeck" <linux@roeck-us.net>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Jonathan Cameron" <jonathan.cameron@huawei.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH] [v3, apply after -rc1] i3c: simplify combined i3c/i2c dependencies
Date: Fri, 06 Feb 2026 09:21:34 +0100	[thread overview]
Message-ID: <879b9cb2-95f3-464f-b300-ff8a8065b451@app.fastmail.com> (raw)
In-Reply-To: <20260205201126.66995e9e@jic23-huawei>

On Thu, Feb 5, 2026, at 21:11, Jonathan Cameron wrote:
> On Wed, 4 Feb 2026 10:15:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
>> On 2/4/26 08:41, Arnd Bergmann wrote:
>> > From: Arnd Bergmann <arnd@arndb.de>
>> > 
>> > All combined i2c/i3c drivers appear to suffer from the same link
>> > time problem when CONFIG_I3C is set to 'm':
>> > 
>> > arm-linux-gnueabi-ld: drivers/iio/magnetometer/mmc5633.o: in function `mmc5633_i3c_driver_init':
>> > mmc5633.c:(.init.text+0x30): undefined reference to `i3c_driver_register_with_owner'
>> > 
>> > This was previously fixed every time by marking individual
>> > drivers as 'depends on I2C; depends on I3C || !I3C', but this gets
>> > tedious and is somewhat confusing.
>> > 
>> > Add a Kconfig symbol 'I3C_OR_I2C' to help replace those dependencies,
>> > and use this in all the existing drivers that had already fixed it
>> > as well as the new mmc5633 driver.
>> > 
>> > Fixes: 6e5f6bf2e3f0 ("iio: magnetometer: Add mmc5633 sensor")
>
> I think can drop the Fixes tag now given there is a fix in between for
> the original issue.

Right, my mistake. 

    Arnd

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c