* [PATCH] i3c: fix missing newline in dev_err messages
@ 2026-03-17 3:40 Haoyu Lu
2026-03-17 8:53 ` Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Haoyu Lu @ 2026-03-17 3:40 UTC (permalink / raw)
To: Alexandre Belloni, Frank Li
Cc: Miquel Raynal, linux-i3c, imx, linux-kernel, haoyu.lu
From: "haoyu.lu" <hechushiguitu666@gmail.com>
Add missing newline to dev_err messages in:
- drivers/i3c/master.c
- drivers/i3c/master/svc-i3c-master.c
Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
---
drivers/i3c/master.c | 2 +-
drivers/i3c/master/svc-i3c-master.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 9e6be49bebb2..27e93fcf2eba 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2396,7 +2396,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
* DEFSLVS command.
*/
if (boardinfo->base.flags & I2C_CLIENT_TEN) {
- dev_err(dev, "I2C device with 10 bit address not supported.");
+ dev_err(dev, "I2C device with 10 bit address not supported.\n");
return -EOPNOTSUPP;
}
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index b84b324e4111..e09a6218bf34 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1268,7 +1268,7 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
/* Configure IBI auto-rules */
ret = svc_i3c_update_ibirules(master);
if (ret)
- dev_err(master->dev, "Cannot handle such a list of devices");
+ dev_err(master->dev, "Cannot handle such a list of devices\n");
rpm_out:
pm_runtime_put_autosuspend(master->dev);
--
2.53.0.windows.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i3c: fix missing newline in dev_err messages
2026-03-17 3:40 [PATCH] i3c: fix missing newline in dev_err messages Haoyu Lu
@ 2026-03-17 8:53 ` Miquel Raynal
2026-03-18 14:30 ` Frank Li
2026-03-18 21:25 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2026-03-17 8:53 UTC (permalink / raw)
To: Haoyu Lu; +Cc: Alexandre Belloni, Frank Li, linux-i3c, imx, linux-kernel
On 17/03/2026 at 11:40:15 +08, Haoyu Lu <hechushiguitu666@gmail.com> wrote:
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
> ---
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i3c: fix missing newline in dev_err messages
2026-03-17 3:40 [PATCH] i3c: fix missing newline in dev_err messages Haoyu Lu
2026-03-17 8:53 ` Miquel Raynal
@ 2026-03-18 14:30 ` Frank Li
2026-03-18 21:25 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-03-18 14:30 UTC (permalink / raw)
To: Haoyu Lu; +Cc: Alexandre Belloni, Miquel Raynal, linux-i3c, imx, linux-kernel
On Tue, Mar 17, 2026 at 11:40:15AM +0800, Haoyu Lu wrote:
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/i3c/master.c | 2 +-
> drivers/i3c/master/svc-i3c-master.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 9e6be49bebb2..27e93fcf2eba 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2396,7 +2396,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> * DEFSLVS command.
> */
> if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> - dev_err(dev, "I2C device with 10 bit address not supported.");
> + dev_err(dev, "I2C device with 10 bit address not supported.\n");
> return -EOPNOTSUPP;
> }
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index b84b324e4111..e09a6218bf34 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1268,7 +1268,7 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
> /* Configure IBI auto-rules */
> ret = svc_i3c_update_ibirules(master);
> if (ret)
> - dev_err(master->dev, "Cannot handle such a list of devices");
> + dev_err(master->dev, "Cannot handle such a list of devices\n");
>
> rpm_out:
> pm_runtime_put_autosuspend(master->dev);
> --
> 2.53.0.windows.1
>
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i3c: fix missing newline in dev_err messages
2026-03-17 3:40 [PATCH] i3c: fix missing newline in dev_err messages Haoyu Lu
2026-03-17 8:53 ` Miquel Raynal
2026-03-18 14:30 ` Frank Li
@ 2026-03-18 21:25 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2026-03-18 21:25 UTC (permalink / raw)
To: Frank Li, Haoyu Lu; +Cc: Miquel Raynal, linux-i3c, imx, linux-kernel
On Tue, 17 Mar 2026 11:40:15 +0800, Haoyu Lu wrote:
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c
Applied, thanks!
[1/1] i3c: fix missing newline in dev_err messages
https://git.kernel.org/i3c/c/7ea9bfee2ee0
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-18 21:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 3:40 [PATCH] i3c: fix missing newline in dev_err messages Haoyu Lu
2026-03-17 8:53 ` Miquel Raynal
2026-03-18 14:30 ` Frank Li
2026-03-18 21:25 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox