From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C21FC43381 for ; Mon, 1 Apr 2019 18:17:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 235CC20883 for ; Mon, 1 Apr 2019 18:17:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y2rI/ejX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="GT7s7C1c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 235CC20883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AhfC6iYzZR6HEz2wLfVVvxQ2PPGbNigAGRdkh8314XM=; b=Y2rI/ejXGD2vKz VjcQcwQ+601gPF/CYLg0aP82lR7orZLVFnTzp5kswmx6qNTptZt2psyqMWxNlB9JmEJbrjnVob9Io OcEBWBCsQVpRKlHl+E/0A5sWGQNZ5wnCBAxKJl8g+jzQ3Icb/fo4O14cLCBK714fc+Ly2jajzKyiM lEpifAm4TNhpyjISvjo6nGyRqSHskG9VvEXCk1EL+eZoXgZST9koGtf0XcG6qKyqlBDbCHCblr1KK /l1Euj5Woe49aauzgOkE7GFo5QrBpYPIJFamGJsZlqbB8KwcFUgiCJ32X79jTc3C3bF3DQz1ym0CV kmfmtcGTlrLbdUwFZ89Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1Uh-0006K4-Qq; Mon, 01 Apr 2019 18:17:15 +0000 Received: from smtprelay2.synopsys.com ([198.182.60.111] helo=smtprelay.synopsys.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1Ue-0006Jk-Qb for linux-i3c@lists.infradead.org; Mon, 01 Apr 2019 18:17:14 +0000 Received: from mailhost.synopsys.com (dc8-mailhost1.synopsys.com [10.13.135.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id EDA8B10C1B85; Mon, 1 Apr 2019 11:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1554142632; bh=1ZzKVO/4dbYPEyyE2FjAJjpx3/FWCNu9iK57oruJh7A=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=GT7s7C1clbfIZK9KqhyM4WWK6JyBzDxgdprF/Mvb1PwoKAyaa5MFzhrOJdEOWar4h 9lvn2QgS/0IkAsmeZw15zdo9I1SXhOtXo7ctWemrGRpc43DIJZglUGBObBIpaYS/v9 RJ/4SB1WApuAEza3NTfbUaUDhVGlVzUYqMN/SpdJW3rZ3/tn94PkswTuB/Mawn+BVa NeJPteAy0tBG6CCQfgV+vmHuNOruO9op2HvWiV5qdCVIsHf+93eiXNVQRVqLGHkJ/y SVLJlrzYZL2l5XZqGfDx1VFB8sheahPSPawMZac28IQ7F/mr+nWybMEvT6Y0QdRG25 esEPQmx/yyVIA== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id D355BA005A; Mon, 1 Apr 2019 18:17:10 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 11:17:10 -0700 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 20:17:08 +0200 Received: from [10.0.2.15] (10.107.19.140) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 20:17:08 +0200 Subject: Re: [PATCH v4 1/6] i3c: add addr and lvr to i2c_dev_desc structure To: Boris Brezillon , Przemyslaw Gaj References: <20190310135843.21154-1-pgaj@cadence.com> <20190310135843.21154-2-pgaj@cadence.com> <20190330153618.48719ee5@collabora.com> From: vitor Message-ID: <87ba262f-384e-711c-4673-103099cdb8ad@synopsys.com> Date: Mon, 1 Apr 2019 19:17:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190330153618.48719ee5@collabora.com> Content-Language: en-US X-Originating-IP: [10.107.19.140] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_111712_871725_A4C7F618 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-i3c@lists.infradead.org, vitor.soares@synopsys.com, rafalc@cadence.com, agolec@cadence.com, bbrezillon@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org Hi, On 30/03/19 14:36, Boris Brezillon wrote: > On Sun, 10 Mar 2019 13:58:38 +0000 > Przemyslaw Gaj wrote: > >> I need to store address and lvr value for I2C devices without static definition >> in DT. This allows secondary master to transmit DEFSLVS command properly. >> >> Signed-off-by: Przemyslaw Gaj >> --- >> include/linux/i3c/master.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h >> index eca8337..3c27d9f 100644 >> --- a/include/linux/i3c/master.h >> +++ b/include/linux/i3c/master.h >> @@ -71,6 +71,9 @@ struct i2c_dev_boardinfo { >> * @common: common part of the I2C device descriptor >> * @boardinfo: pointer to the boardinfo attached to this I2C device >> * @dev: I2C device object registered to the I2C framework >> + * @addr: I2C device address >> + * @lvr: LVR (Legacy Virtual Register) needed by the I3C core to know about >> + * the I2C device limitations >> * >> * Each I2C device connected on the bus will have an i2c_dev_desc. >> * This object is created by the core and later attached to the controller >> @@ -84,6 +87,8 @@ struct i2c_dev_desc { >> struct i3c_i2c_dev_desc common; >> const struct i2c_dev_boardinfo *boardinfo; >> struct i2c_client *dev; >> + u16 addr; >> + u8 lvr; > You also need to remove lvr from i2c_dev_boardinfo and adjust the code > to use i2c_dev_desc->addr and i2c_dev_desc->lvr in this patch, not in > patch 3. > Why can't we keep the lvr and addr in i2c_dev_boardinfo and need this information on i2c_dev_desc? >> }; >> >> /** _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c