Re: [PATCH 1/1] i3c: master: svc: Flush FIFO before sending Dynamic Address Assignment(DAA)

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Conor Culhane <conor.culhane@silvaco.com>,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 linux-i3c@lists.infradead.org (moderated list:SILVACO I3C
	DUAL-ROLE MASTER),  linux-kernel@vger.kernel.org (open list),
	 imx@lists.linux.dev
Subject: Re: [PATCH 1/1] i3c: master: svc: Flush FIFO before sending Dynamic Address Assignment(DAA)
Date: Fri, 31 Jan 2025 09:52:48 +0100	[thread overview]
Message-ID: <87bjvnz7of.fsf@bootlin.com> (raw)
In-Reply-To: <20250129162250.3629189-1-Frank.Li@nxp.com> (Frank Li's message of "Wed, 29 Jan 2025 11:22:50 -0500")

On 29/01/2025 at 11:22:50 -05, Frank Li <Frank.Li@nxp.com> wrote:

> Ensure the FIFO is empty before issuing the DAA command to prevent
> incorrect command data from being sent. Align with other data transfers,
> such as svc_i3c_master_start_xfer_locked(), which flushes the FIFO before
> sending a command.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Hotplug stress test find a wrong byte send out, this patch can resolve
> this issue although have not identify which operation cause a byte left in
> FIFO.

That's exactly what I understood from your commit log, I have mixed
feelings about the patch because it probably hides something bigger. Not
that I want to break users, but there is likely something else to do to
avoid it. Is there any chance you can check the content of the FIFO and
warn before flushing (at least while debugging)?

Anyway,

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c