From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42FC7C5479D for ; Wed, 11 Jan 2023 13:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=54xqbCntbSjgaucGWy0bhvMAfoHa2QX52f7xRilm5mg=; b=Ai06P2w1H6zYN6 Wlu77HhtggnWJ5QhDNXYA4KSurL1a/8LJTJoeRvTd/Y5Yva04w/zy3Onaf0G5DRh2GpbrS0Sq2AJd 6b9DSnxeF7uN5JAaNHPaYQHM4dEdYK+01q8IktReshIlfR9LLQcNupAYs2nM3aARfG+pgOwMfyYvR lyMjuup4biR6hmi/nfkwpbBbfWX7Av+JePQRA7QYj6Zj1Vv6Dg1sgaP1tW5LoTvOY32wJ9I/ZTo++ JVe6mCXMGkPqNELaY1XcBPwPPtIAgDv0pIlamasWUCr05iJi1SVVWXKhK5FFSRwMv4P3dPsd/urq8 hIFZp5zcJIsSU0whz1zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFbEL-00Bbg4-Ds; Wed, 11 Jan 2023 13:33:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXlW-00AdHV-9K for linux-i3c@lists.infradead.org; Wed, 11 Jan 2023 09:51:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 756AF61B8A; Wed, 11 Jan 2023 09:51:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54F6DC433F1; Wed, 11 Jan 2023 09:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430685; bh=z0ZYgHqL1YLvYl+ue5zNy1KMy+u3shk6BmiAvHiQZSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xZGcZ5JDRrdXTJbt9tLPDzh24ToBaCeG04aIrg63SxaV0mqioT6pGZXGHiVeh9ZOU sO0JuLfJTFUVrJVMPgoU9Fwio7tkoa1uh4VeY/xzIKAbqvAAsfPDw+kuuk3E42lxBv sJ9yu85to26aoTWWeVLBJDsI3mtwYFGQ3RchmYyA= Date: Wed, 11 Jan 2023 10:51:22 +0100 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Jens Axboe , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Maximilian Luz , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Matthew Wilcox (Oracle)" , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Andy Shevchenko , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_015126_463278_BC999084 X-CRM114-Status: GOOD ( 18.51 ) X-Mailman-Approved-At: Wed, 11 Jan 2023 05:33:24 -0800 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Wed, Nov 23, 2022 at 01:38:05PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 23, 2022 at 1:25 PM Greg Kroah-Hartman > wrote: > > > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Cc: Yehezkel Bernat > > Cc: Jiri Slaby > > Cc: Heikki Krogerus > > Cc: "Matthew Wilcox (Oracle)" > > Cc: "Martin K. Petersen" > > Cc: Chaitanya Kulkarni > > Cc: Ming Lei > > Cc: Jilin Yuan > > Cc: Alan Stern > > Cc: Andy Shevchenko > > Cc: Sakari Ailus > > Cc: Jason Gunthorpe > > Cc: Thomas Gleixner > > Cc: Ira Weiny > > Cc: Dan Williams > > Cc: Won Chung > > Cc: alsa-devel@alsa-project.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-acpi@vger.kernel.org > > Cc: linux-block@vger.kernel.org > > Cc: linux-i2c@vger.kernel.org > > Cc: linux-i3c@lists.infradead.org > > Cc: linux-input@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-serial@vger.kernel.org > > Cc: linux-usb@vger.kernel.org > > Cc: linux1394-devel@lists.sourceforge.net > > Cc: platform-driver-x86@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Rafael J. Wysocki > > (which my ACPI maintainer hat on). thanks for the review, I'll add it to the v2 patch. greg k-h -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c