From: Simon Horman <simon.horman@corigine.com>
To: Matt Johnston <matt@codeconstruct.com.au>
Cc: linux-i3c@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH net-next v2 3/3] mctp i3c: MCTP I3C driver
Date: Thu, 20 Jul 2023 18:35:38 +0100 [thread overview]
Message-ID: <ZLlwaoOMNymjXQ6I@corigine.com> (raw)
In-Reply-To: <20230717040638.1292536-4-matt@codeconstruct.com.au>
On Mon, Jul 17, 2023 at 12:06:38PM +0800, Matt Johnston wrote:
...
Hi Matt,
> +/* Returns the 48 bit Provisioned Id from an i3c_device_info.pid */
> +static void pid_to_addr(u64 pid, u8 addr[PID_SIZE])
> +{
> + pid = cpu_to_be64(pid);
This assigns a be64 value to a u64 variable,
which is incorrect from a Sparse annotation perspective.
> + memcpy(addr, ((u8 *)&pid) + 2, PID_SIZE);
> +}
...
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2023-07-21 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 4:06 [PATCH net-next v2 0/3] I3C MCTP net driver Matt Johnston
2023-07-17 4:06 ` [PATCH net-next v2 1/3] dt-bindings: i3c: Add mctp-controller property Matt Johnston
2023-07-17 6:19 ` Krzysztof Kozlowski
2023-07-19 9:10 ` Alexandre Belloni
2023-07-17 4:06 ` [PATCH net-next v2 2/3] i3c: Add support for bus enumeration & notification Matt Johnston
2023-07-19 1:57 ` Jakub Kicinski
2023-07-19 9:11 ` Alexandre Belloni
2023-07-19 9:10 ` Alexandre Belloni
2023-07-17 4:06 ` [PATCH net-next v2 3/3] mctp i3c: MCTP I3C driver Matt Johnston
2023-07-19 1:54 ` Jakub Kicinski
2023-07-19 2:00 ` Jakub Kicinski
2023-07-20 17:35 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLlwaoOMNymjXQ6I@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox