Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1

Krzysztof Kozlowski
2024-01-17T06:45:23Z

On 16/01/2024 22:31, Frank Li wrote:

>>>>>>>
>>>>>>> Is it okay for 'silvaco,i3c-target-imx93'?
>>>>
>>>> No, because imx93 is product of NXP, not Silvaco.
>>>>
>>>> You need regular SoC-block compatibles, just like we have for all other
>>>> snps, dwc and cdns.
>>>
>>> "nxp,imx93-svc-i3c-target" ?
>>
>> Could be, now please point me to patch adding such code to DTS. I would
>> like to see the real use case for it.
>
> This part have not sent to review yet. basically in imx93evk.dts add
>
> &i3c1 {
> compatible = "silvaco,i3c-target-v1";
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&pinctrl_i3c1>;
> pinctrl-1 = <&pinctrl_i3c1>;
> status = "okay"
> }

Overriding compatible is not desired. It also supports here the
statement that this is the same hardware.

Best regards,
Krzysztof