Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1

Frank Li
2024-01-12T15:32:20Z

On Fri, Jan 12, 2024 at 08:38:39AM +0100, Krzysztof Kozlowski wrote:
> On 10/01/2024 18:52, Frank Li wrote:
> > Add compatible string 'silvaco,i3c-target-v1' for target mode.
>
> Your subject has some multiple prefixes? Why there is one more ":"?
> Just: add XYZ device
>
>
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > index 133855f11b4f5..17849c91d4d2b 100644
> > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > @@ -4,7 +4,7 @@
> > $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > -title: Silvaco I3C master
> > +title: Silvaco I3C master/target
> >
> > maintainers:
> > - Conor Culhane <conor.culhane@silvaco.com>
> > @@ -14,8 +14,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: silvaco,i3c-master-v1
>
> NAK, you got comment, didn't you? Why did you ignore it? It's like third
> time you try to push it ignoring what we keep asking. Pushing the same
> without resolving anything in previous discussion is not acceptable and
> it feels like waste of my time.

I review previous comments. The previous RFC patches and I just want I3C
expert review to check if there are comments about whole software
architecture. Of course, thank you for your comments about "slave".

Go back this binding doc problem.

"No, it's the same device.

Anyway, this was not tested.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.
"

It is the same devices, work at difference mode (master and target).
what's do you want to change to?

Copy to new file like pci/pci-ep? all context is the same, except for
compatible string.

Frank
>
>
> > -
>
> Why are you removing the blank line?
>
>
> Best regards,
> Krzysztof