Re: [PATCH v2 1/1] MAINTAINERS: I3C: Add Frank Li as nxp I3C controller driver maintainer

Miquel Raynal
2024-10-01T10:10:36Z

Hi Frank,

Frank.li@nxp.com wrote on Mon, 30 Sep 2024 13:08:06 -0400:

> On Mon, Sep 30, 2024 at 06:22:35PM +0200, Miquel Raynal wrote:
> > Hi Frank,
> >
> > Frank.li@nxp.com wrote on Mon, 9 Sep 2024 16:05:32 -0400:
> >
> > > On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote:
> > > > Add Frank Li as NXP i3c controller driver as maintainer and add mail list
> > > > imx@lists.linux.dev for it.
> > > >
> > > > Add Frank Li as I3C subsystem reviewer.
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > >
> > > Miquel:
> > > Any comments?
> >
> > I guess we'll happily take your feedback on patches targeting the SVC
> > driver, you've been working a lot on it. However, in general there has
> > been a lot of discussions happening on your substantial patchsets and
> > little to no convergence in the end.
>
> I think this can't prevent no any feedback at this thread for more than
> 1 month.

Well, there's been a lot of discussion, then no convergence, that's
what I am pointing out as well. You cannot say there has been no
discussion.

> Basic, this patch did two things,

Actually 3, and this is usually too much.

> one add mail list imx@lists.linux.dev to
> keep us track all imx related patch in one mail list. generally, we don't
> check linux-i3c mail list frequently.
>
> The other things is add me to maintainer, If you have concern about it.
> You'd better said as
> - point to the path to be maintainer, such as do reviewer first for some
> times.
> - or simple reject this, I can post the patch, which only add
> imx@lists.linux.dev.
>
> Keep simple, two questions:
> 1: are you agree on add imx@lists.linux.dev?
> 2: are you agree on I as reviewer?

I've already answered these questions and made a difference between
reviewing driver changes and core changes.

> > I understand you want to push your
> > patches upstream and I also want to make things move forward, but maybe
> > one of the reasons for the stalls is the lack of fluent exchanges
> > between us and the difficulty to explain bigger pictures in a clear
> > way.

Thanks,
Miquèl