Re: [PATCH v4 5/8] i3c: target: add svc target controller support

kernel test robot
2024-01-27T00:59:02Z

Hi Frank,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus robh/for-next linus/master v6.8-rc1 next-20240125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/i3c-add-target-mode-support/20240124-071453
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20240123231043.3891847-6-Frank.Li%40nxp.com
patch subject: [PATCH v4 5/8] i3c: target: add svc target controller support
config: i386-buildonly-randconfig-003-20240127 (https://download.01.org/0day-ci/archive/20240127/202401270838.wdxHPaAT-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401270838.wdxHPaAT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401270838.wdxHPaAT-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
include/linux/i3c/target.h: In function 'i3c_target_ctrl_alloc_request':
include/linux/i3c/target.h:280:9: error: implicit declaration of function 'kzalloc'; did you mean 'xa_alloc'? [-Werror=implicit-function-declaration]
req = kzalloc(sizeof(*req), gfp_flags);
^~~~~~~
xa_alloc
>> include/linux/i3c/target.h:280:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
req = kzalloc(sizeof(*req), gfp_flags);
^
include/linux/i3c/target.h: In function 'i3c_target_ctrl_free_request':
include/linux/i3c/target.h:306:3: error: implicit declaration of function 'kfree'; did you mean '__free'? [-Werror=implicit-function-declaration]
kfree(req);
^~~~~
__free
In file included from include/linux/resource_ext.h:11:0,
from include/linux/acpi.h:13,
from include/linux/i2c.h:13,
from include/linux/i3c/device.h:13,
from drivers/i3c/master/svc-i3c-target.c:24:
include/linux/slab.h: At top level:
>> include/linux/slab.h:227:6: warning: conflicting types for 'kfree'
void kfree(const void *objp);
^~~~~
In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
include/linux/i3c/target.h:306:3: note: previous implicit declaration of 'kfree' was here
kfree(req);
^~~~~
In file included from include/linux/resource_ext.h:11:0,
from include/linux/acpi.h:13,
from include/linux/i2c.h:13,
from include/linux/i3c/device.h:13,
from drivers/i3c/master/svc-i3c-target.c:24:
>> include/linux/slab.h:709:37: error: conflicting types for 'kzalloc'
static inline __alloc_size(1) void *kzalloc(size_t size, gfp_t flags)
^~~~~~~
In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
include/linux/i3c/target.h:280:9: note: previous implicit declaration of 'kzalloc' was here
req = kzalloc(sizeof(*req), gfp_flags);
^~~~~~~
cc1: some warnings being treated as errors

vim +280 include/linux/i3c/target.h

ebda81e6094f36 Frank Li 2024-01-23 264
ebda81e6094f36 Frank Li 2024-01-23 265 /**
ebda81e6094f36 Frank Li 2024-01-23 266 * i3c_target_ctrl_alloc_request() - Alloc an I3C transfer
ebda81e6094f36 Frank Li 2024-01-23 267 * @ctrl: I3C target controller device
ebda81e6094f36 Frank Li 2024-01-23 268 * @gfp_flags: additional gfp flags used when allocating the buffers
ebda81e6094f36 Frank Li 2024-01-23 269 *
ebda81e6094f36 Frank Li 2024-01-23 270 * Returns: Zero for success, or an error code in case of failure
ebda81e6094f36 Frank Li 2024-01-23 271 */
ebda81e6094f36 Frank Li 2024-01-23 272 static inline struct i3c_request *
ebda81e6094f36 Frank Li 2024-01-23 273 i3c_target_ctrl_alloc_request(struct i3c_target_ctrl *ctrl, gfp_t gfp_flags)
ebda81e6094f36 Frank Li 2024-01-23 274 {
ebda81e6094f36 Frank Li 2024-01-23 275 struct i3c_request *req = NULL;
ebda81e6094f36 Frank Li 2024-01-23 276
ebda81e6094f36 Frank Li 2024-01-23 277 if (ctrl && ctrl->ops && ctrl->ops->alloc_request)
ebda81e6094f36 Frank Li 2024-01-23 278 req = ctrl->ops->alloc_request(ctrl, gfp_flags);
ebda81e6094f36 Frank Li 2024-01-23 279 else
ebda81e6094f36 Frank Li 2024-01-23 @280 req = kzalloc(sizeof(*req), gfp_flags);
ebda81e6094f36 Frank Li 2024-01-23 281
ebda81e6094f36 Frank Li 2024-01-23 282 if (req)
ebda81e6094f36 Frank Li 2024-01-23 283 req->ctrl = ctrl;
ebda81e6094f36 Frank Li 2024-01-23 284
ebda81e6094f36 Frank Li 2024-01-23 285 return req;
ebda81e6094f36 Frank Li 2024-01-23 286 }
ebda81e6094f36 Frank Li 2024-01-23 287

--
0-DAY CI Kernel Test Service