Re: [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h

Ilpo Järvinen
2024-01-27T19:53:01Z

On Tue, 23 Jan 2024, Frank Li wrote:

> SVC i3c is a dual role controller. Move probe() into svc-i3c-main.c. This
> prepares to support target probe depending on dts "mode" settings.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/i3c/master/Makefile | 3 +-
> drivers/i3c/master/svc-i3c-main.c | 52 +++++++++++++++++++++++++++++
> drivers/i3c/master/svc-i3c-master.c | 34 ++++---------------
> drivers/i3c/master/svc-i3c.h | 11 ++++++
> 4 files changed, 71 insertions(+), 29 deletions(-)
> create mode 100644 drivers/i3c/master/svc-i3c-main.c
> create mode 100644 drivers/i3c/master/svc-i3c.h
>
> diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile
> index 3e97960160bc8..484cb81f45821 100644
> --- a/drivers/i3c/master/Makefile
> +++ b/drivers/i3c/master/Makefile
> @@ -2,5 +2,6 @@
> obj-$(CONFIG_CDNS_I3C_MASTER) += i3c-master-cdns.o
> obj-$(CONFIG_DW_I3C_MASTER) += dw-i3c-master.o
> obj-$(CONFIG_AST2600_I3C_MASTER) += ast2600-i3c-master.o
> -obj-$(CONFIG_SVC_I3C_MASTER) += svc-i3c-master.o
> +svc-i3c-objs += svc-i3c-main.o svc-i3c-master.o
> +obj-$(CONFIG_SVC_I3C_MASTER) += svc-i3c.o
> obj-$(CONFIG_MIPI_I3C_HCI) += mipi-i3c-hci/
> diff --git a/drivers/i3c/master/svc-i3c-main.c b/drivers/i3c/master/svc-i3c-main.c
> new file mode 100644
> index 0000000000000..053b2bd9d8317
> --- /dev/null
> +++ b/drivers/i3c/master/svc-i3c-main.c

...

> +module_platform_driver(svc_i3c_master);
> \ No newline at end of file

> diff --git a/drivers/i3c/master/svc-i3c.h b/drivers/i3c/master/svc-i3c.h
> new file mode 100644
> index 0000000000000..0bd1f0112a071
> --- /dev/null
> +++ b/drivers/i3c/master/svc-i3c.h

...

> +#endif
> \ No newline at end of file

Add the trailing newline characters.

--
i.