Re: [PATCH RFC 3/7] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller

Rob Herring
2025-06-25T21:38:57Z

On Wed, Jun 11, 2025 at 11:39:27AM +0200, Wolfram Sang wrote:
> From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>
> Available in RZ/G3S and G3E SoCs. The G3S has 17 interrupts, the G3E 16
> with the "HDR exit" interrupt missing. This interrupt is put to the end
> of the list, so we can handle the difference using "minItems" instead of
> defining a separate interrupt list per SoC.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Tommaso also did a version with two interrupt lists and using 'oneOf'. I
> prefer this version but maybe the other one is preferred upstream?
>
> .../devicetree/bindings/i3c/renesas,i3c.yaml | 186 ++++++++++++++++++
> 1 file changed, 186 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
> new file mode 100644
> index 000000000000..e6e6c57bb56c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
> @@ -0,0 +1,186 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/renesas,i3c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas I3C Bus Interface
> +
> +maintainers:
> + - Wolfram Sang <wsa+renesas@sang-engineering.com>
> + - Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - renesas,r9a08g045-i3c # RZ/G3S
> + - renesas,r9a09g047-i3c # RZ/G3E
> + - const: renesas,i3c
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Non-recoverable internal error interrupt
> + - description: Normal transfer error interrupt
> + - description: Normal transfer abort interrupt
> + - description: Normal response status buffer full interrupt
> + - description: Normal command buffer empty interrupt
> + - description: Normal IBI status buffer full interrupt
> + - description: Normal Rx data buffer full interrupt
> + - description: Normal Tx data buffer empty interrupt
> + - description: Normal receive status buffer full interrupt
> + - description: START condition detection interrupt
> + - description: STOP condition detection interrupt
> + - description: Transmit end interrupt
> + - description: NACK detection interrupt
> + - description: Arbitration lost interrupt
> + - description: Timeout detection interrupt
> + - description: Wake-up condition detection interrupt
> + - description: HDR Exit Pattern detection interrupt
> + minItems: 16
> +
> + interrupt-names:
> + items:
> + - const: ierr
> + - const: terr
> + - const: abort
> + - const: resp
> + - const: cmd
> + - const: ibi
> + - const: rx
> + - const: tx
> + - const: rcv
> + - const: st
> + - const: sp
> + - const: tend
> + - const: nack
> + - const: al
> + - const: tmo
> + - const: wu
> + - const: exit
> + minItems: 16
> +
> + clocks:
> + oneOf:
> + - items:
> + - description: APB bus clock
> + - description: transfer clock
> + - items:
> + - description: APB bus clock
> + - description: SFRs clock
> + - description: transfer clock

It's a new binding, why don't you put SFRs clock last and simplify the
schema?

> +
> + clock-names:
> + oneOf:
> + - items:
> + - const: pclk
> + - const: tclk
> + - items:
> + - const: pclk
> + - const: pclkrw
> + - const: tclk