On Tue, Jun 24, 2025 at 02:08:45PM -0400, Frank Li wrote: > On Tue, Jun 24, 2025 at 11:06:04AM +0200, Jorge Marques wrote: > > The I3C abstraction expects u8 buffers, but some controllers operate with > > a 32-bit bus width FIFO and cannot flag valid bytes individually. To avoid > > reading or writing outside the buffer bounds, use 32-bit accesses where > > possible and apply memcpy for any remaining bytes > > > > Signed-off-by: Jorge Marques > > Reviewed-by: Frank Li > > > --- > > drivers/i3c/internals.h | 37 +++++++++++++++++++++++++++++++++++++ Is there a reason we don't put this in 'include/linux/i3c/master.h'? 'internals.h' is used for the core only so far, and '#include <../something.h>' also looks a bit like a layering violation.